Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2646863003: Delete third_party/apple_sample_code/ (Closed)

Created:
3 years, 11 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[abandoned] Delete third_party/apple_sample_code/ BUG=

Patch Set 1 #

Patch Set 2 : Delete third_party/apple_sample_code/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -332 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 2 chunks +0 lines, -20 lines 0 comments Download
D third_party/apple_sample_code/BUILD.gn View 1 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/apple_sample_code/ImageAndTextCell.h View 1 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/apple_sample_code/ImageAndTextCell.m View 1 1 chunk +0 lines, -175 lines 0 comments Download
D third_party/apple_sample_code/LICENSE View 1 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/apple_sample_code/OWNERS View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/apple_sample_code/README.chromium View 1 1 chunk +0 lines, -19 lines 0 comments Download
M tools/licenses.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (10 generated)
aelias_OOO_until_Jul13
The CQ bit was checked by aelias@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-20 04:13:24 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646863003/1
3 years, 11 months ago (2017-01-20 04:13:35 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-20 04:35:30 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 11 months ago (2017-01-20 04:35:31 UTC) #4
aelias_OOO_until_Jul13
The CQ bit was checked by aelias@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-20 05:04:49 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646863003/20001
3 years, 11 months ago (2017-01-20 05:05:14 UTC) #6
aelias_OOO_until_Jul13
Description was changed from ========== [WIP] Try deleting outlineView function BUG= ========== to ========== Delete ...
3 years, 11 months ago (2017-01-20 05:07:03 UTC) #7
aelias_OOO_until_Jul13
aelias@chromium.org changed reviewers: + thakis@chromium.org
3 years, 11 months ago (2017-01-20 05:07:03 UTC) #8
aelias_OOO_until_Jul13
aelias@chromium.org changed reviewers: - thakis@chromium.org
3 years, 11 months ago (2017-01-20 05:16:13 UTC) #9
aelias_OOO_until_Jul13
3 years, 11 months ago (2017-01-20 05:17:41 UTC) #10 
Description was changed from

==========
Delete third_party/apple_sample_code/

The only remaining use of it was a function "outlineView" that was
itself dead code.  I deleted that along with the dependency.

BUG=
==========

to

==========
[abandoned] Delete third_party/apple_sample_code/


BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698