Fix unused lambda captures in //chrome, //services/ui and //ui.

Fix unused lambda captures in //chrome, //services/ui and //ui.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in //chrome, //services/ui and //ui.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is unnecessary.

BUG=681136
Review-Url: https://codereview.chromium.org/2646863002
Cr-Commit-Position: refs/heads/master@{#445062}
Committed: https://chromium.googlesource.com/chromium/src/+/ea33b332c6d28c050b657baada979a22ae5ad3a6

[krasin1, 2017-01-19 22:23:41]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 22:24:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2017-01-19 22:27:18]

krasin@chromium.org changed reviewers:
+ sky@chromium.org

[krasin1, 2017-01-19 22:27:18]

Hi Scott,

this is another trivial cleanup CL. In this case, I am lifting the roadblock
that prevents us from rolling the new version of Clang compiler to src/

The change is not expected to change any logic, it's just removing the unused
lambda captures (e.g. the variables from the outer context that a made available
for the lambda code to use).

Please, take a look.

[commit-bot: I haz the power, 2017-01-19 23:26:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 23:26:59]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-20 00:42:31]

LGTM

[krasin1, 2017-01-20 15:36:32]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2017-01-20 15:36:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 15:40:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484926592352940, "parent_rev":
"bbbf64cf6fa9c2ec032d680d1fbb08a60e5915ba", "commit_rev":
"ea33b332c6d28c050b657baada979a22ae5ad3a6"}

[commit-bot: I haz the power, 2017-01-20 15:41:08]

Description was changed from

==========
Fix unused lambda captures in //chrome, //services/ui and //ui.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in //chrome, //services/ui and //ui.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is unnecessary.

BUG=681136
==========

to

==========
Fix unused lambda captures in //chrome, //services/ui and //ui.

Clang just got a new warning about unused lambda captures,
and that requires us to clean all places with this issue
across all the Chromium code base. This CL fixes all such
cases in //chrome, //services/ui and //ui.

An example of a code that is no longer considered normal is

auto g = [i, j]() { printf("%d\n", i); };

in which j is never used in the lambda and therefore its capture is unnecessary.

BUG=681136

Review-Url: https://codereview.chromium.org/2646863002
Cr-Commit-Position: refs/heads/master@{#445062}
Committed:
https://chromium.googlesource.com/chromium/src/+/ea33b332c6d28c050b657baada97...
==========

[commit-bot: I haz the power, 2017-01-20 15:41:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea33b332c6d28c050b657baada97...