Mojo C++ bindings: Simplify associated interface API.

Mojo C++ bindings: Simplify associated interface API.

AssociatedInterfacePtrInfo/Request pair can be created in a pending state and attach to a message pipe later.

AssociatedGroup will become a class used by the binding internal code. Users will no longer need to pass an AssociatedGroup argument when creating associated interfaces.

BUG=682334
Review-Url: https://codereview.chromium.org/2646853003
Cr-Commit-Position: refs/heads/master@{#450494}
Committed: https://chromium.googlesource.com/chromium/src/+/2859a2ac06ab5d9df6706cc45525dc4a2085051c

[yzshen1, 2017-01-24 22:44:14]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 22:44:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 22:55:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 22:55:33]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yzshen1, 2017-01-24 23:05:46]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 23:06:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-01-24 23:08:44]

Description was changed from

==========
Mojo C++ bindings: Simplify associated interface API.

AssociatedInterfacePtrInfo/Request pair can be created in a pending state and
attach to a message pipe later.

Eventually associated group will be removed.

BUG=682334
==========

to

==========
Mojo C++ bindings: Simplify associated interface API.

AssociatedInterfacePtrInfo/Request pair can be created in a pending state and
attach to a message pipe later.

AssociatedGroup will be removed in a follow-up CL.

BUG=682334
==========

[yzshen1, 2017-01-24 23:09:34]

yzshen@chromium.org changed reviewers:
+ dcheng@chromium.org, rockot@chromium.org

[yzshen1, 2017-01-24 23:09:35]

Hi, Ken and Daniel.

Would you please take a look?

Ken: everything
Daniel: security review for the mojom file change, which just removed one
control message.

[commit-bot: I haz the power, 2017-01-25 00:13:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 00:13:58]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[yzshen1, 2017-01-30 20:55:20]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 20:56:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-01-30 21:14:48]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 21:15:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-01-30 21:21:43]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 21:22:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-01-30 21:28:24]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 21:28:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 22:19:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 22:19:51]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dcheng, 2017-01-31 02:02:38]

dcheng@chromium.org changed reviewers:
+ ochang@chromium.org

[dcheng, 2017-01-31 02:02:39]

ochang@ has volunteered to help review this. I'm generally happy about removals
from mojom files, but it'd be good to have someone more familiar with mojo guts
look over the core bits here.

[yzshen1, 2017-01-31 18:32:40]

On 2017/01/31 02:02:39, dcheng wrote:
> ochang@ has volunteered to help review this. I'm generally happy about
removals
> from mojom files, but it'd be good to have someone more familiar with mojo
guts
> look over the core bits here.

Thanks, Oliver and Daniel!
I am fixing the bot failure. That may require some non-trivial change. So you
could hold off reviewing this CL until I send you an update saying that it is
ready.

[yzshen1, 2017-02-01 23:26:27]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 23:26:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 00:37:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 00:37:39]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yzshen1, 2017-02-08 21:13:15]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 21:14:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 21:18:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 21:18:48]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yzshen1, 2017-02-08 21:47:55]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 21:48:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 22:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 22:57:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yzshen1, 2017-02-10 01:03:32]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 01:04:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 01:38:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 01:38:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yzshen1, 2017-02-10 03:09:38]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 03:10:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 04:08:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 04:08:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yzshen1, 2017-02-10 20:04:01]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 20:04:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 22:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:08:58]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2017-02-10 22:31:36]

On 2017/01/31 18:32:40, yzshen1 wrote:
> On 2017/01/31 02:02:39, dcheng wrote:
> > ochang@ has volunteered to help review this. I'm generally happy about
> removals
> > from mojom files, but it'd be good to have someone more familiar with mojo
> guts
> > look over the core bits here.
> 
> Thanks, Oliver and Daniel!
> I am fixing the bot failure. That may require some non-trivial change. So you
> could hold off reviewing this CL until I send you an update saying that it is
> ready.

Hi, reviewers!
Now this CL is ready. (All try bots were green with patch 20.) Please take a
look!

[yzshen1, 2017-02-10 22:35:50]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 22:36:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 00:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 00:14:51]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2017-02-13 22:05:09]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 22:05:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-02-13 22:31:34]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 22:32:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-02-13 22:48:51]

Hi, Ken.

PTAL. I have switched from AssociatedGroupControllerGetter to
AssociatedGroup::GetController().

Thanks!

[commit-bot: I haz the power, 2017-02-14 00:55:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 00:55:50]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-02-14 07:39:27]

LGTM! just some nits and clarifying questions

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/associated_group_controller.h (right):

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/associated_group_controller.h:29: // Associates an
interface with the message pipe.
nit: Maybe worth clarifying: "with this AssociatedGroupController's message
pipe"

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/associated_group_controller.h:79: // Notifies the peer
of |handle| that it has joined the associated group.
nit: I find the "it" makes this a bit ambiguous. How about   "Notifies
|handle|'s peer that |handle| has joined the associated group."?

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/associated_interface_ptr.h (right):

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/associated_interface_ptr.h:264: // TODO(yzshen): Change
callsites to directly use GetIsolatedProxy().
btw (no action required) I think if we're going to update all the callsites
eventually anyway, we should rename it to MakeIsolatedRequest for consistency -
WDYT?

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/interface_endpoint_client.h (right):

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/interface_endpoint_client.h:111: void
QueryVersion(const base::Callback<void(uint32_t)>& callback);
nit: Any reason not to leave the ControlMessageProxy accessor here instead of
having a bunch of explicit forwarding methods?

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/interface_endpoint_client.h:155: void
HandlePendingHandleEvent(
nitty nit: Maybe just OnAssociationEvent? The double "Handle" is a little
unfortunate

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.cc (right):

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.cc:52: //
Intentionally keep |group_controller_| unchanged.
nit: Is it worth explaining why we don't reset group_controller_? It's not clear
to me why we couldn't, given the finality of Close.

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.cc:158: //
OnPeerClosedBeforeAssociation() on the peer handle.
Could you clarify when this can happen? Is this essentially just when two
threads race between Close() and NotifyPeerAssociated() for peers of the same
endpoint?

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/scoped_interface_endpoint_handle.h (right):

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/scoped_interface_endpoint_handle.h:93: bool
NotifyPeerAssociation(
nit: Maybe the name should also reflect that this completes the association of
this handle as well, since this is responsible for setting pending = false etc

[yzshen1, 2017-02-14 19:10:06]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[yzshen1, 2017-02-14 19:10:27]

Thanks! PTAL

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/associated_group_controller.h (right):

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/associated_group_controller.h:29: // Associates an
interface with the message pipe.
On 2017/02/14 07:39:27, Ken Rockot wrote:
> nit: Maybe worth clarifying: "with this AssociatedGroupController's message
> pipe"

Done.

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/associated_group_controller.h:79: // Notifies the peer
of |handle| that it has joined the associated group.
On 2017/02/14 07:39:27, Ken Rockot wrote:
> nit: I find the "it" makes this a bit ambiguous. How about   "Notifies
> |handle|'s peer that |handle| has joined the associated group."?

Actually, it is "|handle|'s peer" who has joined this associated group. |handle|
will be sent to the remote side (which is a different associated group).

Updated the comment to make it more clear.

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/associated_interface_ptr.h (right):

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/associated_interface_ptr.h:264: // TODO(yzshen): Change
callsites to directly use GetIsolatedProxy().
On 2017/02/14 07:39:27, Ken Rockot wrote:
> btw (no action required) I think if we're going to update all the callsites
> eventually anyway, we should rename it to MakeIsolatedRequest for consistency
-
> WDYT?

Right. That was what I was thinking as well.

Updated the TODO.

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/interface_endpoint_client.h (right):

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/interface_endpoint_client.h:111: void
QueryVersion(const base::Callback<void(uint32_t)>& callback);
On 2017/02/14 07:39:27, Ken Rockot wrote:
> nit: Any reason not to leave the ControlMessageProxy accessor here instead of
> having a bunch of explicit forwarding methods?

At the beginning, I allowed FlushForTesting() to be called in any case (by
ignoring the call if the handle is pending), but later decided that it is more
consistent to fail it like the other two methods. That made all of them trivial
forwarding functions. However, I still kept this change because I slightly
prefer
  interface_endpoint_->QueryVersion(...);
to
  interface_endpoint_->control_message_proxy()->QueryVersion(...);

I feel that the latter seems to expose implementation details.

That being said, I don't have a very strong opinion here. If you like the
original way, I could revert.
WDYT?

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/interface_endpoint_client.h:155: void
HandlePendingHandleEvent(
On 2017/02/14 07:39:27, Ken Rockot wrote:
> nitty nit: Maybe just OnAssociationEvent? The double "Handle" is a little
> unfortunate

Good point. Changed!

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.cc (right):

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.cc:52: //
Intentionally keep |group_controller_| unchanged.
On 2017/02/14 07:39:27, Ken Rockot wrote:
> nit: Is it worth explaining why we don't reset group_controller_? It's not
clear
> to me why we couldn't, given the finality of Close.

Added the following explanation to the code:

          // That is because the callback created by
          // CreateGroupControllerGetter() could still be used after this point,
          // potentially from another thread. We would like it to continue
          // returning the same group controller.
          //
          // Imagine there is a ThreadSafeForwarder A:
          // (1) On the IO thread, A's underlying associated interface pointer
          //     is closed.
          // (2) On the proxy thread, the user makes a call on A to pass an
          //     associated request B_asso_req. The callback returned by
          //     CreateGroupControllerGetter() is used to associate B_asso_req.
          // (3) On the proxy thread, the user immediately binds B_asso_ptr_info
          //     to B_asso_ptr and makes calls on it.
          //
          // If we reset |group_controller_| in step (1), step (2) won't be able
          // to associate B_asso_req. Therefore, in step (3) B_asso_ptr won't be
          // able to serialize associated endpoints or send message because it
          // is still in "pending_association" state and doesn't have a group
          // controller.
          //
          // We could "address" this issue by ignoring messages if there isn't a
          // group controller. But the side effect is that we cannot detect
          // programming errors of "using associated interface pointer before
          // sending associated request".

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.cc:158: //
OnPeerClosedBeforeAssociation() on the peer handle.
On 2017/02/14 07:39:27, Ken Rockot wrote:
> Could you clarify when this can happen? Is this essentially just when two
> threads race between Close() and NotifyPeerAssociated() for peers of the same
> endpoint?

Yes. To be more accurate, it is the race between Close() of endpoint A and
NotifyPeerAssociation() of endpoint A_peer (i.e., it notifies A_peer's peer,
which is A).

I updated the comment.

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/scoped_interface_endpoint_handle.h (right):

https://codereview.chromium.org/2646853003/diff/440001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/scoped_interface_endpoint_handle.h:93: bool
NotifyPeerAssociation(
On 2017/02/14 07:39:27, Ken Rockot wrote:
> nit: Maybe the name should also reflect that this completes the association of
> this handle as well, since this is responsible for setting pending = false etc

Done. I changed to

// The peer of this handle will join |peer_group_controller|.
bool NotifyAssociation(
      InterfaceId id,
      scoped_refptr<AssociatedGroupController> peer_group_controller);

[commit-bot: I haz the power, 2017-02-14 19:11:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-02-14 19:19:17]

Description was changed from

==========
Mojo C++ bindings: Simplify associated interface API.

AssociatedInterfacePtrInfo/Request pair can be created in a pending state and
attach to a message pipe later.

AssociatedGroup will be removed in a follow-up CL.

BUG=682334
==========

to

==========
Mojo C++ bindings: Simplify associated interface API.

AssociatedInterfacePtrInfo/Request pair can be created in a pending state and
attach to a message pipe later.

AssociatedGroup will become a class used by the binding internal code. Users
will no longer need to pass an AssociatedGroup argument when creating associated
interfaces.

BUG=682334
==========

[Oliver Chang, 2017-02-14 19:50:05]

lgtm, but I'm afraid it's been a while since I've looked at Mojo code so this
was a rather shallow review.

[commit-bot: I haz the power, 2017-02-14 20:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 20:57:45]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2017-02-14 21:08:57]

On 2017/02/14 19:50:05, Oliver Chang wrote:
> lgtm, but I'm afraid it's been a while since I've looked at Mojo code so this
> was a rather shallow review.

Thanks Oliver!

[Ken Rockot(use gerrit already), 2017-02-14 22:04:46]

Thanks, all LGTM!

[yzshen1, 2017-02-14 22:15:58]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2017-02-14 22:16:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 22:24:30]

CQ is committing da patch.

Bot data: {"patchset_id": 460001, "attempt_start_ts": 1487110558211900,
"parent_rev": "592b0657eb77130cebf1c8847944a59298d640b5", "commit_rev":
"2859a2ac06ab5d9df6706cc45525dc4a2085051c"}

[commit-bot: I haz the power, 2017-02-14 22:25:05]

Description was changed from

==========
Mojo C++ bindings: Simplify associated interface API.

AssociatedInterfacePtrInfo/Request pair can be created in a pending state and
attach to a message pipe later.

AssociatedGroup will become a class used by the binding internal code. Users
will no longer need to pass an AssociatedGroup argument when creating associated
interfaces.

BUG=682334
==========

to

==========
Mojo C++ bindings: Simplify associated interface API.

AssociatedInterfacePtrInfo/Request pair can be created in a pending state and
attach to a message pipe later.

AssociatedGroup will become a class used by the binding internal code. Users
will no longer need to pass an AssociatedGroup argument when creating associated
interfaces.

BUG=682334

Review-Url: https://codereview.chromium.org/2646853003
Cr-Commit-Position: refs/heads/master@{#450494}
Committed:
https://chromium.googlesource.com/chromium/src/+/2859a2ac06ab5d9df6706cc45525...
==========

[commit-bot: I haz the power, 2017-02-14 22:25:06]

Committed patchset #24 (id:460001) as
https://chromium.googlesource.com/chromium/src/+/2859a2ac06ab5d9df6706cc45525...