Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2646803003: Rename confusing method name. (Closed)

Created:
3 years, 11 months ago by mtomasz
Modified:
3 years, 11 months ago
Reviewers:
lazyboy, battre
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename confusing method name. ExtensionsService::DisableUserExtensions(ids) doesn't disable the passed extensions, but all user extensions except the passed ids. It's very hard to notice that from the caller side, and the actual code does completely opposite. This CL renames this confusing method name. BUG=680429 TEST=Refactoring only. Review-Url: https://codereview.chromium.org/2646803003 Cr-Commit-Position: refs/heads/master@{#445603} Committed: https://chromium.googlesource.com/chromium/src/+/294bb3e342259c73d2abddd5b759104d34854b17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/extensions/extension_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
mtomasz
@benwells: PTAL. Thanks.
3 years, 11 months ago (2017-01-20 02:33:24 UTC) #5
mtomasz
@battre: PTAL (@benwells is OOO). Thanks.
3 years, 11 months ago (2017-01-20 02:36:40 UTC) #7
battre
LGTM and thank you!
3 years, 11 months ago (2017-01-20 07:19:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646803003/1
3 years, 11 months ago (2017-01-20 07:25:15 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/346257)
3 years, 11 months ago (2017-01-20 07:41:56 UTC) #14
mtomasz
@lazyboy: PTAL. Thanks.
3 years, 11 months ago (2017-01-23 00:56:23 UTC) #16
lazyboy
thanks, lgtm
3 years, 11 months ago (2017-01-23 18:43:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646803003/1
3 years, 11 months ago (2017-01-24 00:27:38 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 02:18:52 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/294bb3e342259c73d2abddd5b759...

Powered by Google App Engine
This is Rietveld 408576698