Chromium Code Reviews
DescriptionMake sure InspectorBaseAgent::disable is not renamed.
When we started blacklisting renaming of "disable" method (in r380773)
the virtual method was implemented by InspectorAgent class. Since then
(in 396629) the virtual method was moved into InspectorBaseAgent class
and consequently blacklisting stopped working - this CL fixes this.
I've tested this CL by running the clang tool on
third_party/WebKit/Source/modules/storage/StorageNamespaceController.cpp
and verifying that "disable" method in core/inspector/InspectorBaseAgent.h
was not renamed after this CL (and was renamed before this CL).
BUG=593446
Review-Url: https://codereview.chromium.org/2646803002
Cr-Commit-Position: refs/heads/master@{#444815}
Committed: https://chromium.googlesource.com/chromium/src/+/535b89a267d880c41efed60526213483ae79e707
Patch Set 1 #
Messages
Total messages: 13 (9 generated)
|
|||||||||||||||||||