Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2646803002: Make sure InspectorBaseAgent::disable is not renamed. (Closed)

Created:
3 years, 11 months ago by Łukasz Anforowicz
Modified:
3 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure InspectorBaseAgent::disable is not renamed. When we started blacklisting renaming of "disable" method (in r380773) the virtual method was implemented by InspectorAgent class. Since then (in 396629) the virtual method was moved into InspectorBaseAgent class and consequently blacklisting stopped working - this CL fixes this. I've tested this CL by running the clang tool on third_party/WebKit/Source/modules/storage/StorageNamespaceController.cpp and verifying that "disable" method in core/inspector/InspectorBaseAgent.h was not renamed after this CL (and was renamed before this CL). BUG=593446 Review-Url: https://codereview.chromium.org/2646803002 Cr-Commit-Position: refs/heads/master@{#444815} Committed: https://chromium.googlesource.com/chromium/src/+/535b89a267d880c41efed60526213483ae79e707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Łukasz Anforowicz
Dana, can you PTAL?
3 years, 11 months ago (2017-01-19 17:59:22 UTC) #4
danakj
LGTM
3 years, 11 months ago (2017-01-19 19:24:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646803002/1
3 years, 11 months ago (2017-01-19 19:25:07 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 19:34:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/535b89a267d880c41efed6052621...

Powered by Google App Engine
This is Rietveld 408576698