Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2646763004: [turbofan] Introduce simplified operators directly in BytecodeGraphBuilder. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce simplified operators directly in BytecodeGraphBuilder. Instead of doing the dance via JSStrictEqual for comparisons with null, undefined or the hole, we can just go to ReferenceEqual directly. Also avoid the Select(x, false, true) dance for negation and use BooleanNot directly. R=mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2646763004 Cr-Commit-Position: refs/heads/master@{#42500} Committed: https://chromium.googlesource.com/v8/v8/+/1c278ebe2dfc81fc04d2fe53fa1e0b16e02c1cdd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 5 chunks +11 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-19 12:43:52 UTC) #1
Benedikt Meurer
Hey Michi, Here's the simplification for the BytecodeGraphBuilder that we talked about. Please take a ...
3 years, 11 months ago (2017-01-19 12:45:36 UTC) #4
Michael Starzinger
LGTM.
3 years, 11 months ago (2017-01-19 13:02:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646763004/1
3 years, 11 months ago (2017-01-19 13:03:44 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 13:13:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1c278ebe2dfc81fc04d2fe53fa1e0b16e02...

Powered by Google App Engine
This is Rietveld 408576698