[turbofan] Optimize typeof o === "object" checks.

[turbofan] Optimize typeof o === "object" checks.

Properly recognize and optimize typeof in a strict/abstract equality
comparison with the string literal "object" to a check for Null or a
check of the map for Receiver instance type and non-callable.

Drive-by-fix: Also optimize typeof o === "function" somewhat, now that
we have the new types for Callable and NonCallable.

R=jarin@chromium.org
BUG=v8:5267
Review-Url: https://codereview.chromium.org/2646763003
Cr-Commit-Position: refs/heads/master@{#42501}
Committed: https://chromium.googlesource.com/v8/v8/+/695026d411edcc222e514aa7090a42554237cb2a

[Benedikt Meurer, 2017-01-19 12:20:44]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 12:20:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-01-19 12:30:27]

lgtm

https://codereview.chromium.org/2646763003/diff/1/src/compiler/effect-control...
File src/compiler/effect-control-linearizer.cc (right):

https://codereview.chromium.org/2646763003/diff/1/src/compiler/effect-control...
src/compiler/effect-control-linearizer.cc:1713: Node* vfalse = __ Word32Equal(
The vfalse name is pretty confusing here - it is certainly does not mean the
false value. How about some less confusing name?

[Benedikt Meurer, 2017-01-19 12:50:32]

https://codereview.chromium.org/2646763003/diff/1/src/compiler/effect-control...
File src/compiler/effect-control-linearizer.cc (right):

https://codereview.chromium.org/2646763003/diff/1/src/compiler/effect-control...
src/compiler/effect-control-linearizer.cc:1713: Node* vfalse = __ Word32Equal(
On 2017/01/19 12:30:27, Jarin wrote:
> The vfalse name is pretty confusing here - it is certainly does not mean the
> false value. How about some less confusing name?

Done.

[Benedikt Meurer, 2017-01-19 12:50:35]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-01-19 12:50:35]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2646763003/#ps20001
(title: "Address comment.")

[commit-bot: I haz the power, 2017-01-19 12:50:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 13:16:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484830235369990,
"parent_rev": "1c278ebe2dfc81fc04d2fe53fa1e0b16e02c1cdd", "commit_rev":
"695026d411edcc222e514aa7090a42554237cb2a"}

[commit-bot: I haz the power, 2017-01-19 13:16:32]

Description was changed from

==========
[turbofan] Optimize typeof o === "object" checks.

Properly recognize and optimize typeof in a strict/abstract equality
comparison with the string literal "object" to a check for Null or a
check of the map for Receiver instance type and non-callable.

Drive-by-fix: Also optimize typeof o === "function" somewhat, now that
we have the new types for Callable and NonCallable.

R=jarin@chromium.org
BUG=v8:5267
==========

to

==========
[turbofan] Optimize typeof o === "object" checks.

Properly recognize and optimize typeof in a strict/abstract equality
comparison with the string literal "object" to a check for Null or a
check of the map for Receiver instance type and non-callable.

Drive-by-fix: Also optimize typeof o === "function" somewhat, now that
we have the new types for Callable and NonCallable.

R=jarin@chromium.org
BUG=v8:5267

Review-Url: https://codereview.chromium.org/2646763003
Cr-Commit-Position: refs/heads/master@{#42501}
Committed:
https://chromium.googlesource.com/v8/v8/+/695026d411edcc222e514aa7090a4255423...
==========

[commit-bot: I haz the power, 2017-01-19 13:16:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/695026d411edcc222e514aa7090a4255423...

[bakkot1, 2017-01-23 19:26:15]

bakkot@gmail.com changed reviewers:
+ bakkot@gmail.com

[bakkot1, 2017-01-23 19:26:16]

https://codereview.chromium.org/2646763003/diff/20001/src/compiler/typer.cc
File src/compiler/typer.cc (right):

https://codereview.chromium.org/2646763003/diff/20001/src/compiler/typer.cc#n...
src/compiler/typer.cc:506: if (type->Is(Type::Callable())) return
t->singleton_true_;
Drive-by comment: document.all is "callable", in that `document.all()` succeeds
(and the 'Callable' type in types.h includes 'kOtherUndetectable', which I'm
guessing is the type of document.all), but `typeof document.all === 'function'`
should evaluate to false. At a glance it looks like this might cause it to
evaluate to true.

[Benedikt Meurer, 2017-02-14 10:18:24]

https://codereview.chromium.org/2646763003/diff/20001/src/compiler/typer.cc
File src/compiler/typer.cc (right):

https://codereview.chromium.org/2646763003/diff/20001/src/compiler/typer.cc#n...
src/compiler/typer.cc:506: if (type->Is(Type::Callable())) return
t->singleton_true_;
Aye, sorry for the delay, just discovered this comment. Can you file a bug
report please?

[bakkot1, 2017-02-14 22:48:40]

On 2017/02/14 10:18:24, Benedikt Meurer wrote:
> https://codereview.chromium.org/2646763003/diff/20001/src/compiler/typer.cc
> File src/compiler/typer.cc (right):
> 
>
https://codereview.chromium.org/2646763003/diff/20001/src/compiler/typer.cc#n...
> src/compiler/typer.cc:506: if (type->Is(Type::Callable())) return
> t->singleton_true_;
> Aye, sorry for the delay, just discovered this comment. Can you file a bug
> report please?

Done: https://bugs.chromium.org/p/v8/issues/detail?id=5972