Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2646763002: Disable logging for media_cenc_utils_fuzzer. (Closed)

Created:
3 years, 11 months ago by mmoroz
Modified:
3 years, 11 months ago
Reviewers:
jrummell, inferno
CC:
chromium-reviews, eme-reviews_chromium.org, fuzzing_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable logging for media_cenc_utils_fuzzer. R=inferno@chromium.org, jrummell@chromium.org BUG=682632 Review-Url: https://codereview.chromium.org/2646763002 Cr-Commit-Position: refs/heads/master@{#445035} Committed: https://chromium.googlesource.com/chromium/src/+/1f80af17c49d09e2d4fbfca567cf81aca19a23ea

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M media/cdm/cenc_utils_fuzzertest.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mmoroz
3 years, 11 months ago (2017-01-19 12:01:26 UTC) #1
inferno
lgtm https://codereview.chromium.org/2646763002/diff/1/media/cdm/cenc_utils_fuzzertest.cc File media/cdm/cenc_utils_fuzzertest.cc (right): https://codereview.chromium.org/2646763002/diff/1/media/cdm/cenc_utils_fuzzertest.cc#newcode13 media/cdm/cenc_utils_fuzzertest.cc:13: Environment() { logging::SetMinLogLevel(logging::LOG_FATAL); } nit: Move logging::SetMinLogLevel(logging::LOG_FATAL); to ...
3 years, 11 months ago (2017-01-19 12:29:45 UTC) #4
mmoroz
Thanks! https://codereview.chromium.org/2646763002/diff/1/media/cdm/cenc_utils_fuzzertest.cc File media/cdm/cenc_utils_fuzzertest.cc (right): https://codereview.chromium.org/2646763002/diff/1/media/cdm/cenc_utils_fuzzertest.cc#newcode13 media/cdm/cenc_utils_fuzzertest.cc:13: Environment() { logging::SetMinLogLevel(logging::LOG_FATAL); } On 2017/01/19 12:29:45, inferno ...
3 years, 11 months ago (2017-01-19 12:36:52 UTC) #5
inferno
lgtm
3 years, 11 months ago (2017-01-19 12:38:38 UTC) #6
jrummell
lgtm
3 years, 11 months ago (2017-01-19 20:10:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646763002/20001
3 years, 11 months ago (2017-01-20 09:33:13 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 10:34:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f80af17c49d09e2d4fbfca567cf...

Powered by Google App Engine
This is Rietveld 408576698