Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2646743002: [turbofan] Improve constant-folding for typeof. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve constant-folding for typeof. Especially support constant-folding typeof for detectable and undetectable receivers. BUG=v8:5267, v8:5270 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2646743002 Cr-Commit-Position: refs/heads/master@{#42494} Committed: https://chromium.googlesource.com/v8/v8/+/c9a980d59ace8c9e7c2a947268e6ddf4db5419f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -56 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/compiler/types.h View 1 chunk +58 lines, -51 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-19 09:51:49 UTC) #1
Benedikt Meurer
Hey Jaro, Here's an easy one that we missed. Please take a look. Thanks, Benedikt
3 years, 11 months ago (2017-01-19 09:53:36 UTC) #4
Jarin
lgtm
3 years, 11 months ago (2017-01-19 09:56:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646743002/1
3 years, 11 months ago (2017-01-19 10:01:23 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 10:26:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c9a980d59ace8c9e7c2a947268e6ddf4db5...

Powered by Google App Engine
This is Rietveld 408576698