Fix unhandled SecurityException in iOS password_controller

Fix unhandled SecurityException in iOS password_controller

BUG=683385
Review-Url: https://codereview.chromium.org/2646733007
Cr-Commit-Position: refs/heads/master@{#446086}
Committed: https://chromium.googlesource.com/chromium/src/+/e5222b703090cfb4e426db7c384a0fd47c980474

[Rick Byers, 2017-01-20 22:45:19]

rbyers@chromium.org changed reviewers:
+ melandory@chromium.org

[Rick Byers, 2017-01-20 22:45:19]

melandory@ PTAL at this trivial fix.

We can't properly test the fix because it's only a problem on WebKit that isn't
yet shipped on iOS: https://trac.webkit.org/changeset/205136

I've never built or landed anything for bling before.  For a trivial fix like
this is the CQ sufficient to smoke test?  Or should I get setup to build it
myself to double check I didn't break anything?

[Rick Byers, 2017-01-23 14:45:29]

The CQ bit was checked by rbyers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 14:45:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 14:46:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 14:46:09]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, no
build URL)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, no build
URL)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, no build
URL)

[melandory, 2017-01-25 13:24:45]

lgtm
On 2017/01/20 22:45:19, Rick Byers wrote:
> melandory@ PTAL at this trivial fix.
> 
> We can't properly test the fix because it's only a problem on WebKit that
isn't
> yet shipped on iOS: https://trac.webkit.org/changeset/205136
> 
> I've never built or landed anything for bling before.  For a trivial fix like
> this is the CQ sufficient to smoke test?  Or should I get setup to build it
> myself to double check I didn't break anything?
I think it is sufficient.

[Rick Byers, 2017-01-25 18:43:08]

On 2017/01/25 13:24:45, melandory wrote:
> lgtm
> On 2017/01/20 22:45:19, Rick Byers wrote:
> > melandory@ PTAL at this trivial fix.
> > 
> > We can't properly test the fix because it's only a problem on WebKit that
> isn't
> > yet shipped on iOS: https://trac.webkit.org/changeset/205136
> > 
> > I've never built or landed anything for bling before.  For a trivial fix
like
> > this is the CQ sufficient to smoke test?  Or should I get setup to build it
> > myself to double check I didn't break anything?
> I think it is sufficient.

Thank you!

[Rick Byers, 2017-01-25 18:43:12]

On 2017/01/25 13:24:45, melandory wrote:
> lgtm
> On 2017/01/20 22:45:19, Rick Byers wrote:
> > melandory@ PTAL at this trivial fix.
> > 
> > We can't properly test the fix because it's only a problem on WebKit that
> isn't
> > yet shipped on iOS: https://trac.webkit.org/changeset/205136
> > 
> > I've never built or landed anything for bling before.  For a trivial fix
like
> > this is the CQ sufficient to smoke test?  Or should I get setup to build it
> > myself to double check I didn't break anything?
> I think it is sufficient.

Thank you!

[Rick Byers, 2017-01-25 18:43:52]

The CQ bit was checked by rbyers@chromium.org

[commit-bot: I haz the power, 2017-01-25 18:44:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 19:34:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485369832991630, "parent_rev":
"0ce28d085257f28db8594dda526f33dc20597fd0", "commit_rev":
"e5222b703090cfb4e426db7c384a0fd47c980474"}

[commit-bot: I haz the power, 2017-01-25 19:34:35]

Description was changed from

==========
Fix unhandled SecurityException in iOS password_controller

BUG=683385
==========

to

==========
Fix unhandled SecurityException in iOS password_controller

BUG=683385

Review-Url: https://codereview.chromium.org/2646733007
Cr-Commit-Position: refs/heads/master@{#446086}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5222b703090cfb4e426db7c384a...
==========

[commit-bot: I haz the power, 2017-01-25 19:34:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5222b703090cfb4e426db7c384a...