Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2646733004: Only look for an app snapshot embedded in a dynamic library in the AOT runtime. (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 11 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only look for an app snapshot embedded in a dynamic library in the AOT runtime. This mode is only intended for simulating iOS for testing. User-facing app snapshots only use regular files. Avoids an error message on Fuchsia. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/ce91f600ae03ab521bbaa202c62593db3a43919a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M runtime/bin/main.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 11 months ago (2017-01-19 20:51:54 UTC) #2
zra
lgtm
3 years, 11 months ago (2017-01-19 20:54:26 UTC) #3
rmacnak
3 years, 11 months ago (2017-01-19 21:00:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce91f600ae03ab521bbaa202c62593db3a43919a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698