Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: runtime/bin/main.cc

Issue 2646733004: Only look for an app snapshot embedded in a dynamic library in the AOT runtime. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index 18520de130e8023969e0f3abad00668260fb4daa..384931c55556f578d567363adf67a4f59b870767 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -1368,6 +1368,7 @@ static bool ReadAppSnapshotBlobs(const char* script_name,
}
+#if defined(DART_PRECOMPILED_RUNTIME)
static bool ReadAppSnapshotDynamicLibrary(const char* script_name,
const uint8_t** vmisolate_buffer,
const uint8_t** isolate_buffer,
@@ -1412,6 +1413,7 @@ static bool ReadAppSnapshotDynamicLibrary(const char* script_name,
return true;
}
+#endif // defined(DART_PRECOMPILED_RUNTIME)
static bool ReadAppSnapshot(const char* script_name,
@@ -1429,9 +1431,15 @@ static bool ReadAppSnapshot(const char* script_name,
instructions_buffer, rodata_buffer)) {
return true;
}
+#if defined(DART_PRECOMPILED_RUNTIME)
+ // For testing AOT with the standalone embedder, we also support loading
+ // from a dynamic library to simulate what happens on iOS.
return ReadAppSnapshotDynamicLibrary(script_name, vmisolate_buffer,
isolate_buffer, instructions_buffer,
rodata_buffer);
+#else
+ return false;
+#endif // defined(DART_PRECOMPILED_RUNTIME)
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698