XMLHttpRequest: Don't use nullness of isolatedWorldSecurityOrigin to determine whether or not it's …

XMLHttpRequest: Don't use nullness of isolatedWorldSecurityOrigin to determine whether or not it's in isolated world

This is aligned with the method used for the Fetch API.

R=yhirano@chromium.org,horo@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2646733003
Cr-Commit-Position: refs/heads/master@{#445368}
Committed: https://chromium.googlesource.com/chromium/src/+/811303bda9ab93b8355de746ddff356f5216bfbf

[tyoshino (SeeGerritForStatus), 2017-01-19 13:15:52]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 13:16:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 14:23:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 14:23:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tyoshino (SeeGerritForStatus), 2017-01-20 05:55:01]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 05:55:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tyoshino (SeeGerritForStatus), 2017-01-20 06:01:47]

Description was changed from

==========
XMLHttpRequest: Don't use nullness of isolatedWorldSecurityOrigin to determine
whether or not it's in isolated world

This is aligned with the method used for the Fetch API.

BUG=none
==========

to

==========
XMLHttpRequest: Don't use nullness of isolatedWorldSecurityOrigin to determine
whether or not it's in isolated world

This is aligned with the method used for the Fetch API.

BUG=none
==========

[tyoshino (SeeGerritForStatus), 2017-01-20 06:01:47]

tyoshino@chromium.org changed reviewers:
+ horo@chromium.org, yhirano@chromium.org

[commit-bot: I haz the power, 2017-01-20 08:37:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 08:37:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tyoshino (SeeGerritForStatus), 2017-01-20 09:58:59]

yhirano, filed http://crbug.com/683074 to address the issue later. I'd like to
do the renaming suggested by you also in the patch to be reviewed by DevTools
folks and renaming create(ExecuteContext*) would require change in the DevTools
directory.

[tyoshino (SeeGerritForStatus), 2017-01-20 09:59:45]

On 2017/01/20 09:58:59, tyoshino wrote:
> yhirano, filed http://crbug.com/683074 to address the issue later. I'd like to

"The issue" means the issue found by yhirano and we discussed offline. Please
see the crbug for details.

> do the renaming suggested by you also in the patch to be reviewed by DevTools
> folks and renaming create(ExecuteContext*) would require change in the
DevTools
> directory.

[horo, 2017-01-23 05:03:44]

lgtm

[yhirano, 2017-01-23 05:05:55]

lgtm

[tyoshino (SeeGerritForStatus), 2017-01-23 10:46:00]

Description was changed from

==========
XMLHttpRequest: Don't use nullness of isolatedWorldSecurityOrigin to determine
whether or not it's in isolated world

This is aligned with the method used for the Fetch API.

BUG=none
==========

to

==========
XMLHttpRequest: Don't use nullness of isolatedWorldSecurityOrigin to determine
whether or not it's in isolated world

This is aligned with the method used for the Fetch API.

R=yhirano@chromium.org,horo@chromium.org
BUG=none
==========

[tyoshino (SeeGerritForStatus), 2017-01-23 10:46:05]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2017-01-23 10:46:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
yhirano@chromium.org, horo@chromium.org
Link to the patchset: https://codereview.chromium.org/2646733003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-23 10:46:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 12:49:08]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485168365524510,
"parent_rev": "29b98cde67e8350d241fad23847ef72fbb939de5", "commit_rev":
"811303bda9ab93b8355de746ddff356f5216bfbf"}

[commit-bot: I haz the power, 2017-01-23 12:49:41]

Description was changed from

==========
XMLHttpRequest: Don't use nullness of isolatedWorldSecurityOrigin to determine
whether or not it's in isolated world

This is aligned with the method used for the Fetch API.

R=yhirano@chromium.org,horo@chromium.org
BUG=none
==========

to

==========
XMLHttpRequest: Don't use nullness of isolatedWorldSecurityOrigin to determine
whether or not it's in isolated world

This is aligned with the method used for the Fetch API.

R=yhirano@chromium.org,horo@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2646733003
Cr-Commit-Position: refs/heads/master@{#445368}
Committed:
https://chromium.googlesource.com/chromium/src/+/811303bda9ab93b8355de746ddff...
==========

[commit-bot: I haz the power, 2017-01-23 12:49:42]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/811303bda9ab93b8355de746ddff...