Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 26467003: Align SkLumaColorFilter with the spec. (Closed)

Created:
7 years, 2 months ago by f(malita)
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Align SkLumaColorFilter with the spec. The spec requires the resulting RGB channels for LuminanceToAlpha to be 0 (and not just scaled by the luminance value</facepalm>): | R' | | 0 0 0 0 0 | | R | | G' | | 0 0 0 0 0 | | G | | B' | = | 0 0 0 0 0 | * | B | | A' | | 0.2125 0.7154 0.0721 0 0 | | A | | 1 | | 0 0 0 0 1 | | 1 | (http://www.w3.org/TR/2011/REC-SVG11-20110816/filters.html#feColorMatrixElement) This doesn't affect luminance masking (which depends only on the resulting alpha channel), but other color filter users may care about all color components. R=reed@google.com,bsalomon@google.com Committed: http://code.google.com/p/skia/source/detail?r=11713

Patch Set 1 #

Patch Set 2 : Clear kA_GrColorComponentFlag in getConstantColorComponents. #

Patch Set 3 : Use kRGB_GrColorComponentFlags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -50 lines) Patch
M gm/lumafilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkLumaColorFilter.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 2 4 chunks +17 lines, -42 lines 0 comments Download
M tests/ColorFilterTest.cpp View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
f(malita)
7 years, 2 months ago (2013-10-08 14:01:03 UTC) #1
reed1
lgtm
7 years, 2 months ago (2013-10-10 19:52:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/26467003/2
7 years, 2 months ago (2013-10-10 20:13:32 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-10 20:13:52 UTC) #4
Message was sent while issue was closed.
Change committed as 11713

Powered by Google App Engine
This is Rietveld 408576698