DescriptionAlign SkLumaColorFilter with the spec.
The spec requires the resulting RGB channels for LuminanceToAlpha to be
0 (and not just scaled by the luminance value</facepalm>):
| R' | | 0 0 0 0 0 | | R |
| G' | | 0 0 0 0 0 | | G |
| B' | = | 0 0 0 0 0 | * | B |
| A' | | 0.2125 0.7154 0.0721 0 0 | | A |
| 1 | | 0 0 0 0 1 | | 1 |
(http://www.w3.org/TR/2011/REC-SVG11-20110816/filters.html#feColorMatrixElement)
This doesn't affect luminance masking (which depends only on the
resulting alpha channel), but other color filter users may care
about all color components.
R=reed@google.com,bsalomon@google.com
Committed: http://code.google.com/p/skia/source/detail?r=11713
Patch Set 1 #Patch Set 2 : Clear kA_GrColorComponentFlag in getConstantColorComponents. #Patch Set 3 : Use kRGB_GrColorComponentFlags. #
Messages
Total messages: 4 (0 generated)
|