include/effects/SkLumaColorFilter.h - Issue 26467003: Align SkLumaColorFilter with the spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkLumaColorFilter.h

Issue 26467003: Align SkLumaColorFilter with the spec. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Use kRGB_GrColorComponentFlags. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/effects/SkLumaColorFilter.h

diff --git a/include/effects/SkLumaColorFilter.h b/include/effects/SkLumaColorFilter.h

index fef06ab12ad7009563aee458948a9822f1c6c1e8..a0c08bbb987b81db23671453f39ac049353d5a85 100644

--- a/include/effects/SkLumaColorFilter.h

+++ b/include/effects/SkLumaColorFilter.h

@@ -15,9 +15,10 @@

* http://www.w3.org/TR/SVG/masking.html#Masking

* http://www.w3.org/TR/css-masking/#MaskValues

- * Each color is scaled by the (unpremultiplied) luminance value:

+ * The resulting color is black with transparency equal to the

+ * luminance value modulated by alpha:

- * C' = [Lum * a, Lum * r, Lum * g, Lum * b]

+ * C' = [ Lum * a, 0, 0, 0 ]

class SK_API SkLumaColorFilter : public SkColorFilter {

« no previous file with comments | « gm/lumafilter.cpp ('k') | src/effects/SkLumaColorFilter.cpp » ('j') | no next file with comments »