Fix crash in mouse event handling with a dirty layout tree.

Fix crash in mouse event handling with a dirty layout tree.

BUG=681369
Review-Url: https://codereview.chromium.org/2646653002
Cr-Commit-Position: refs/heads/master@{#444863}
Committed: https://chromium.googlesource.com/chromium/src/+/921bcf9b346434464e9c0ee809d409c23237edb0

[chrishtr, 2017-01-18 23:15:12]

Description was changed from

==========
none


none


none


none


none


none


none


none


none


none

BUG=
==========

to

==========
Fix crash in mouse event handling with a dirty layout tree.

BUG=681369
==========

[chrishtr, 2017-01-18 23:16:20]

chrishtr@chromium.org changed reviewers:
+ wkorman@chromium.org

[chrishtr, 2017-01-18 23:16:21]

https://codereview.chromium.org/2646653002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/selection/select-delete-in-event-handler.html
(right):

https://codereview.chromium.org/2646653002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/select-delete-in-event-handler.html:5:
<script type="text/javascript">
I spent quite a while reducing the unminimized ClusterFuzz repro case, and this
is as small as I could
get it.

[chrishtr, 2017-01-18 23:16:26]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 23:17:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2017-01-18 23:49:56]

lgtm

https://codereview.chromium.org/2646653002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/MouseEventManager.cpp (right):

https://codereview.chromium.org/2646653002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/MouseEventManager.cpp:734: // so get the
new LayoutObject again.
rm 'new', since it's new this time, but wasn't last time. Well, it might be new
this time. Maybe just rephrase to "so get the LayoutObject again in case it's
new."

[commit-bot: I haz the power, 2017-01-19 01:07:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 01:07:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2017-01-19 19:47:40]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-01-19 19:47:40]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2646653002/#ps40001
(title: "none")

[commit-bot: I haz the power, 2017-01-19 19:48:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-01-19 19:48:35]

https://codereview.chromium.org/2646653002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/MouseEventManager.cpp (right):

https://codereview.chromium.org/2646653002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/MouseEventManager.cpp:734: // so get the
new LayoutObject again.
On 2017/01/18 at 23:49:56, wkorman wrote:
> rm 'new', since it's new this time, but wasn't last time. Well, it might be
new this time. Maybe just rephrase to "so get the LayoutObject again in case
it's new."

Done.

[chrishtr, 2017-01-19 20:52:30]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-01-19 20:52:31]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2646653002/#ps60001
(title: "none")

[commit-bot: I haz the power, 2017-01-19 20:52:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 22:26:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484859150761400,
"parent_rev": "bb1aaf95ea8fd6a5815d512a690ac8587ded2e7d", "commit_rev":
"921bcf9b346434464e9c0ee809d409c23237edb0"}

[commit-bot: I haz the power, 2017-01-19 22:26:58]

Description was changed from

==========
Fix crash in mouse event handling with a dirty layout tree.

BUG=681369
==========

to

==========
Fix crash in mouse event handling with a dirty layout tree.

BUG=681369

Review-Url: https://codereview.chromium.org/2646653002
Cr-Commit-Position: refs/heads/master@{#444863}
Committed:
https://chromium.googlesource.com/chromium/src/+/921bcf9b346434464e9c0ee809d4...
==========

[commit-bot: I haz the power, 2017-01-19 22:26:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/921bcf9b346434464e9c0ee809d4...