android: Tweak readback context memory limits

android: Tweak readback context memory limits

This context is used for readbacks only, and is destroyed after all
readbacks are done. And readback memory comes from the mapped memory
pool.

Lower the transfer buffer pool to 128k. The readback memory doesn't come
from this pool, so there is no reason it's computed from the screen size.

Lower the mapped memory reclaim limit to 4k. Note this is not the
maximum allocation size, so there is no correctness issue here. It also
lowers the chunk size, ie allocations are rounded up to a multiple of
the chunk. There are very few (only one most of the time) allocations
from this pool, having a lower chunk size should not have have a big
impact on perf (from reuse), but lowers memory overhead.

BUG=680690
Review-Url: https://codereview.chromium.org/2646643002
Cr-Commit-Position: refs/heads/master@{#444579}
Committed: https://chromium.googlesource.com/chromium/src/+/b9ee881336aafb25b77a02b0620605696e2200bc

[boliu, 2017-01-18 23:15:34]

Description was changed from

==========
android: Tweak readback context memory limits

This context is used for readbacks only, and is destroyed after all
readbacks are done. And readback memory comes from the mapped memory
pool.

Lower the transfer buffer pool to 128k. The readback memory doesn't come
from this pool, so there is no reason it's computed from the screen size.

Lower the mapped memory reclaim limit to 4k. Note this is not the
maximum allocation size, so there is no correctness issue here. It also
lowers the chunk size, ie allocations are rounded up to a multiple of
the chunk. There are very few (only one most of the time) allocations
from this pool, having a lower chunk size should not have have a big
impact on perf (due to re-use issues), but lowers any memory overhead.

BUG=680690
==========

to

==========
android: Tweak readback context memory limits

This context is used for readbacks only, and is destroyed after all
readbacks are done. And readback memory comes from the mapped memory
pool.

Lower the transfer buffer pool to 128k. The readback memory doesn't come
from this pool, so there is no reason it's computed from the screen size.

Lower the mapped memory reclaim limit to 4k. Note this is not the
maximum allocation size, so there is no correctness issue here. It also
lowers the chunk size, ie allocations are rounded up to a multiple of
the chunk. There are very few (only one most of the time) allocations
from this pool, having a lower chunk size should not have have a big
impact on perf (from reuse), but lowers memory overhead.

BUG=680690
==========

[boliu, 2017-01-18 23:19:35]

boliu@chromium.org changed reviewers:
+ danakj@chromium.org

[boliu, 2017-01-18 23:19:35]

hey Dana, can you take a look. you were the last person before me to touch this
memory limit :p

[danakj, 2017-01-18 23:21:55]

LGTM

https://codereview.chromium.org/2646643002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2646643002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:199:
limits.max_transfer_buffer_size = 128 * 1024;;
double ;;

[boliu, 2017-01-19 00:00:51]

thanks!

https://codereview.chromium.org/2646643002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2646643002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:199:
limits.max_transfer_buffer_size = 128 * 1024;;
On 2017/01/18 23:21:55, danakj (slow) wrote:
> double ;;

oops, fixed

[boliu, 2017-01-19 00:01:55]

The CQ bit was checked by boliu@chromium.org

[boliu, 2017-01-19 00:01:55]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2646643002/#ps20001
(title: "semicolon")

[commit-bot: I haz the power, 2017-01-19 00:03:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 01:03:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484784115704710,
"parent_rev": "d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda", "commit_rev":
"b9ee881336aafb25b77a02b0620605696e2200bc"}

[commit-bot: I haz the power, 2017-01-19 01:05:35]

Description was changed from

==========
android: Tweak readback context memory limits

This context is used for readbacks only, and is destroyed after all
readbacks are done. And readback memory comes from the mapped memory
pool.

Lower the transfer buffer pool to 128k. The readback memory doesn't come
from this pool, so there is no reason it's computed from the screen size.

Lower the mapped memory reclaim limit to 4k. Note this is not the
maximum allocation size, so there is no correctness issue here. It also
lowers the chunk size, ie allocations are rounded up to a multiple of
the chunk. There are very few (only one most of the time) allocations
from this pool, having a lower chunk size should not have have a big
impact on perf (from reuse), but lowers memory overhead.

BUG=680690
==========

to

==========
android: Tweak readback context memory limits

This context is used for readbacks only, and is destroyed after all
readbacks are done. And readback memory comes from the mapped memory
pool.

Lower the transfer buffer pool to 128k. The readback memory doesn't come
from this pool, so there is no reason it's computed from the screen size.

Lower the mapped memory reclaim limit to 4k. Note this is not the
maximum allocation size, so there is no correctness issue here. It also
lowers the chunk size, ie allocations are rounded up to a multiple of
the chunk. There are very few (only one most of the time) allocations
from this pool, having a lower chunk size should not have have a big
impact on perf (from reuse), but lowers memory overhead.

BUG=680690

Review-Url: https://codereview.chromium.org/2646643002
Cr-Commit-Position: refs/heads/master@{#444579}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9ee881336aafb25b77a02b06206...
==========

[commit-bot: I haz the power, 2017-01-19 01:05:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b9ee881336aafb25b77a02b06206...