Issue 26466006: Update default app first run dialog to match new mocks

Issue 26466006: Update default app first run dialog to match new mocks (Closed)

Created:
7 years, 2 months ago by Dmitry Polukhin

Modified:
7 years, 2 months ago

Reviewers:
Marijn Kruisselbrink, asargent_no_longer_on_chrome, sky

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, msw

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update default app first run dialog to match new mocks + Remove button replaced with Cancel + Description removed from the dialog for security reasons + Changed heading and removed title for views BUG=296393 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228637

Patch Set 1 #

Patch Set 2 : remove title #

Patch Set 3 : removed changes that should go to separate CL #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -15 lines)			Patch
M	chrome/app/generated_resources.grd	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_prompt.cc	View	1	5 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_install_dialog_view.cc	View	1	4 chunks	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Dmitry Polukhin

+ Marijn please do OWNER review for extensions code.

7 years, 2 months ago (2013-10-14 18:40:13 UTC) #5

Dmitry Polukhin

+ sky@ for OWNER review in chrome/browser/ui/views/*

7 years, 2 months ago (2013-10-14 21:43:59 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/26466006/11001

7 years, 2 months ago (2013-10-15 00:26:56 UTC) #9

Message was sent while issue was closed.

Change committed as 228637

Expand Messages | Collapse Messages