Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8032)

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 26466006: Update default app first run dialog to match new mocks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: removed changes that should go to separate CL Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_install_prompt.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
index 59a9d047954834a5f90d3a702b7c8abb520bedd0..5575e9f391d087411c41aeb9fd63c2cfe47686a7 100644
--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
@@ -128,6 +128,10 @@ class ExtensionInstallDialogView : public views::DialogDelegateView,
virtual void Layout() OVERRIDE;
virtual gfx::Size GetPreferredSize() OVERRIDE;
+ // views::WidgetDelegate
+ virtual bool ShouldShowWindowTitle() const OVERRIDE;
+ virtual bool ShouldShowCloseButton() const OVERRIDE;
+
// views::LinkListener:
virtual void LinkClicked(views::Link* source, int event_flags) OVERRIDE;
@@ -417,10 +421,7 @@ ExtensionInstallDialogView::ExtensionInstallDialogView(
icon_row_span = 4;
} else if (prompt.ShouldShowPermissions()) {
size_t permission_count = prompt.GetPermissionCount();
- if (is_first_run()) {
- // In first run case we have separator.
- icon_row_span = 1;
- } else if (permission_count > 0) {
+ if (permission_count > 0) {
// Also span the permission header and each of the permission rows (all
// have a padding row above it).
icon_row_span = 3 + permission_count * 2;
@@ -490,7 +491,7 @@ ExtensionInstallDialogView::ExtensionInstallDialogView(
layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
if (prompt.GetPermissionCount() > 0) {
- if (is_inline_install() || is_first_run()) {
+ if (is_inline_install()) {
layout->StartRow(0, column_set_id);
layout->AddView(new views::Separator(views::Separator::HORIZONTAL),
3, 1, views::GridLayout::FILL, views::GridLayout::FILL);
@@ -707,6 +708,14 @@ gfx::Size ExtensionInstallDialogView::GetPreferredSize() {
return dialog_size_;
}
+bool ExtensionInstallDialogView::ShouldShowWindowTitle() const {
+ return false;
+}
+
+bool ExtensionInstallDialogView::ShouldShowCloseButton() const {
+ return false;
+}
+
// static
ExtensionInstallPrompt::ShowDialogCallback
ExtensionInstallPrompt::GetDefaultShowDialogCallback() {
« no previous file with comments | « chrome/browser/extensions/extension_install_prompt.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698