Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2646573002: [M56 fork] Fix DeviceDisplayInfo UnsatisfiedLinkError (Closed)

Created:
3 years, 11 months ago by boliu
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[M56 fork] Fix DeviceDisplayInfo UnsatisfiedLinkError There's a non-trivial window of time during start up, after display listener is registered, but before native library is loaded. This crash happens if the user rotates the device in this window. Note DeviceDisplayInfo is deleted in M57 already, so M57 is not affected. BUG=681613 R=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2646573002 . Cr-Commit-Position: refs/branch-heads/2924@{#798} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/c0ad513dc3af6c42bb44a4626f5031d2d89c66ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
boliu
ptal, I'll request merge after review
3 years, 11 months ago (2017-01-18 19:32:23 UTC) #2
Ted C
lgtm
3 years, 11 months ago (2017-01-18 19:39:58 UTC) #3
boliu
3 years, 11 months ago (2017-01-19 00:37:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c0ad513dc3af6c42bb44a4626f5031d2d89c66ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698