[NTP] Prevent Long Publisher pushing Offline Badge off a card.

[NTP] Prevent Long Publisher pushing Offline Badge off a card.

With long publishers, small screens, large font sizes or some
combination of the above the publisher attribution can push the Offline
Badge off the right hand side of the Card.

By using weights we can make the TextView ellipsize before pushing the
Offline Badge off the card.

BUG=678568
Review-Url: https://codereview.chromium.org/2646533002
Cr-Commit-Position: refs/heads/master@{#444744}
Committed: https://chromium.googlesource.com/chromium/src/+/a1193bdc94a5163af5cd0a71bf438c44fa08fd16

[PEConn, 2017-01-18 17:05:41]

The CQ bit was checked by peconn@chromium.org to run a CQ dry run

[PEConn, 2017-01-18 17:05:55]

peconn@chromium.org changed reviewers:
+ bauerb@chromium.org

[PEConn, 2017-01-18 17:05:56]

PTAL!

[commit-bot: I haz the power, 2017-01-18 17:06:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 17:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 17:43:52]

Dry run: This issue passed the CQ dry run.

[Michael van Ouwerkerk, 2017-01-18 19:43:48]

mvanouwerkerk@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2017-01-18 19:43:49]

https://codereview.chromium.org/2646533002/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/new_tab_page_snippets_card.xml (right):

https://codereview.chromium.org/2646533002/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/new_tab_page_snippets_card.xml:45:
android:layout_width="wrap_content"
I expected this might lead to a width greater than the parent and then clipping,
or other types of weirdness. So this works thanks to the combination of weight
and ellipsize? Did you test it on a few older versions of Android?

[Bernhard Bauer, 2017-01-19 10:21:45]

Oh, awesome! LGTM.

[PEConn, 2017-01-19 15:49:14]

The CQ bit was checked by peconn@chromium.org

[Michael van Ouwerkerk, 2017-01-19 15:49:26]

lgtm

[commit-bot: I haz the power, 2017-01-19 15:49:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 15:54:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484840954894680,
"parent_rev": "d50ce8a895fae5909c2ef1128ee8cb16fef43e64", "commit_rev":
"a1193bdc94a5163af5cd0a71bf438c44fa08fd16"}

[commit-bot: I haz the power, 2017-01-19 15:54:42]

Description was changed from

==========
[NTP] Prevent Long Publisher pushing Offline Badge off a card.

With long publishers, small screens, large font sizes or some
combination of the above the publisher attribution can push the Offline
Badge off the right hand side of the Card.

By using weights we can make the TextView ellipsize before pushing the
Offline Badge off the card.

BUG=678568
==========

to

==========
[NTP] Prevent Long Publisher pushing Offline Badge off a card.

With long publishers, small screens, large font sizes or some
combination of the above the publisher attribution can push the Offline
Badge off the right hand side of the Card.

By using weights we can make the TextView ellipsize before pushing the
Offline Badge off the card.

BUG=678568

Review-Url: https://codereview.chromium.org/2646533002
Cr-Commit-Position: refs/heads/master@{#444744}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1193bdc94a5163af5cd0a71bf43...
==========

[commit-bot: I haz the power, 2017-01-19 15:54:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a1193bdc94a5163af5cd0a71bf43...