Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/browser/printing/pdf_to_emf_converter.h

Issue 2646523003: Refactor pdf_to_emf_converter (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/pdf_to_emf_converter.h
diff --git a/chrome/browser/printing/pdf_to_emf_converter.h b/chrome/browser/printing/pdf_to_emf_converter.h
index 1f52715274065a1103add15ec17b951b81727caa..730cd6431e438d6e26a0cee7242338ca2ca629cc 100644
--- a/chrome/browser/printing/pdf_to_emf_converter.h
+++ b/chrome/browser/printing/pdf_to_emf_converter.h
@@ -15,17 +15,17 @@ namespace printing {
class MetafilePlayer;
struct PdfRenderSettings;
-class PdfToEmfConverter {
+class PdfConverter {
public:
- typedef base::Callback<void(int page_count)> StartCallback;
- typedef base::Callback<void(int page_number,
- float scale_factor,
- std::unique_ptr<MetafilePlayer> emf)>
- GetPageCallback;
+ using StartCallback = base::Callback<void(int page_count)>;
+ using GetPageCallback =
+ base::Callback<void(int page_number,
+ float scale_factor,
+ std::unique_ptr<MetafilePlayer> file)>;
- virtual ~PdfToEmfConverter();
+ virtual ~PdfConverter();
- static std::unique_ptr<PdfToEmfConverter> CreateDefault();
+ static std::unique_ptr<PdfConverter> CreatePdfToEmfConverter();
// Starts conversion of PDF provided as |data|. Calls |start_callback|
// with positive |page_count|. |page_count| is 0 if initialization failed.
@@ -40,8 +40,8 @@ class PdfToEmfConverter {
// if conversion succeeded.
virtual void GetPage(int page_number,
const GetPageCallback& get_page_callback) = 0;
-};
+};
} // namespace printing
#endif // CHROME_BROWSER_PRINTING_PDF_TO_EMF_CONVERTER_H_
« no previous file with comments | « no previous file | chrome/browser/printing/pdf_to_emf_converter.cc » ('j') | chrome/browser/printing/pdf_to_emf_converter.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698