Refactor pdf_to_emf_converter

Refactor pdf_to_emf_converter

Refactor pdf_to_emf_converter.* to limit duplicated code when postscript
printing is added, see https://codereview.chromium.org/2633573002/

BUG=None

Review-Url: https://codereview.chromium.org/2646523003
Cr-Commit-Position: refs/heads/master@{#444614}
Committed: https://chromium.googlesource.com/chromium/src/+/8baf95592462fbc5d4ffcc9857ffe16162147608

[rbpotter, 2017-01-18 21:57:59]

Description was changed from

==========
Refactor pdf_to_emf_converter

Refactor pdf_to_emf_converter.* to limit duplicated code when postscript
printing is added, see https://codereview.chromium.org/2633573002/

BUG=None
==========

to

==========
Refactor pdf_to_emf_converter

Refactor pdf_to_emf_converter.* to limit duplicated code when postscript
printing is added, see https://codereview.chromium.org/2633573002/

BUG=None
==========

[rbpotter, 2017-01-18 21:58:00]

rbpotter@chromium.org changed reviewers:
+ vitalybuka@chromium.org

[rbpotter, 2017-01-18 21:58:05]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 21:58:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 23:09:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 23:09:09]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[rbpotter, 2017-01-18 23:29:32]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 23:30:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2017-01-19 00:07:12]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 00:07:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Vitaly Buka (NO REVIEWS), 2017-01-19 00:35:09]

lgtm

https://codereview.chromium.org/2646523003/diff/1/chrome/browser/printing/pdf...
File chrome/browser/printing/pdf_to_emf_converter.cc (right):

https://codereview.chromium.org/2646523003/diff/1/chrome/browser/printing/pdf...
chrome/browser/printing/pdf_to_emf_converter.cc:95: : public
content::UtilityProcessHostClient {
Class comments should go before class, not inside.

https://codereview.chromium.org/2646523003/diff/1/chrome/browser/printing/pdf...
chrome/browser/printing/pdf_to_emf_converter.cc:109: public:
CL needs "git cl format"

[rbpotter, 2017-01-19 00:47:31]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 00:48:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 01:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 01:46:24]

Dry run: This issue passed the CQ dry run.

[rbpotter, 2017-01-19 02:46:15]

https://codereview.chromium.org/2646523003/diff/1/chrome/browser/printing/pdf...
File chrome/browser/printing/pdf_to_emf_converter.cc (right):

https://codereview.chromium.org/2646523003/diff/1/chrome/browser/printing/pdf...
chrome/browser/printing/pdf_to_emf_converter.cc:95: : public
content::UtilityProcessHostClient {
On 2017/01/19 00:35:09, Vitaly Buka wrote:
> Class comments should go before class, not inside.

Done.

https://codereview.chromium.org/2646523003/diff/1/chrome/browser/printing/pdf...
chrome/browser/printing/pdf_to_emf_converter.cc:109: public:
On 2017/01/19 00:35:09, Vitaly Buka wrote:
> CL needs "git cl format"

Done.

[rbpotter, 2017-01-19 02:56:24]

The CQ bit was checked by rbpotter@chromium.org

[rbpotter, 2017-01-19 02:56:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
vitalybuka@chromium.org
Link to the patchset: https://codereview.chromium.org/2646523003/#ps100001
(title: "Format")

[commit-bot: I haz the power, 2017-01-19 02:56:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 03:00:23]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484794584193440,
"parent_rev": "381fe1bb9f6bf01ff4c0690ced1143f17f12a805", "commit_rev":
"8baf95592462fbc5d4ffcc9857ffe16162147608"}

[commit-bot: I haz the power, 2017-01-19 03:00:54]

Description was changed from

==========
Refactor pdf_to_emf_converter

Refactor pdf_to_emf_converter.* to limit duplicated code when postscript
printing is added, see https://codereview.chromium.org/2633573002/

BUG=None
==========

to

==========
Refactor pdf_to_emf_converter

Refactor pdf_to_emf_converter.* to limit duplicated code when postscript
printing is added, see https://codereview.chromium.org/2633573002/

BUG=None

Review-Url: https://codereview.chromium.org/2646523003
Cr-Commit-Position: refs/heads/master@{#444614}
Committed:
https://chromium.googlesource.com/chromium/src/+/8baf95592462fbc5d4ffcc9857ff...
==========

[commit-bot: I haz the power, 2017-01-19 03:00:58]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/8baf95592462fbc5d4ffcc9857ff...