Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2646503002: Split svg/dom/transform-parser.html (Closed)

Created:
3 years, 11 months ago by fs
Modified:
3 years, 11 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, chromium-reviews, fuzzing_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split svg/dom/transform-parser.html This CL splits the mentioned test into two to alleviate the potential for test timeouts. The bulk of the test is moved to a JS file, and the js-test dependency is dropped since the only useful output of this test is the console log generated. The TestExpectations entry is dropped. BUG=664849 Review-Url: https://codereview.chromium.org/2646503002 Cr-Commit-Position: refs/heads/master@{#444418} Committed: https://chromium.googlesource.com/chromium/src/+/7e800d7672ea681b08ecad44d273d3db1689af1c

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
fs
I was hoping that the diff of the -expected.txt file would be a bit more ...
3 years, 11 months ago (2017-01-18 16:30:13 UTC) #4
Stephen Chennney
LGTM. Thanks for helping out with this.
3 years, 11 months ago (2017-01-18 17:26:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646503002/1
3 years, 11 months ago (2017-01-18 18:05:24 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 18:11:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e800d7672ea681b08ecad44d273...

Powered by Google App Engine
This is Rietveld 408576698