Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 26465007: Update valgrind suppressions (Closed)

Created:
7 years, 2 months ago by robertphillips
Modified:
7 years, 2 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

The valgrind bot isn't crashing anymore so we can make some progress on the suppressions

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -870 lines) Patch
M gm/valgrind.supp View 2 chunks +7 lines, -435 lines 0 comments Download
M tests/valgrind.supp View 2 chunks +7 lines, -435 lines 0 comments Download
A tools/valgrind.supp View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
7 years, 2 months ago (2013-10-08 14:36:46 UTC) #1
borenet
LGTM. The bots are currently ignoring the suppressions. This change should fix it: https://codereview.chromium.org/26500002/
7 years, 2 months ago (2013-10-08 15:11:48 UTC) #2
robertphillips
7 years, 2 months ago (2013-10-08 15:37:35 UTC) #3
Message was sent while issue was closed.
committed as r11650

Powered by Google App Engine
This is Rietveld 408576698