Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2646463002: [turbofan] Fix translation of uint32 deopt immediates. (Closed)

Created:
3 years, 11 months ago by Michael Starzinger
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix translation of uint32 deopt immediates. This makes sure 32-bit constants that are used as {MachineType::Uint32} by the deoptimization translation are also interpreted as such when the literals are collected. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-681983 BUG=chromium:681983 Review-Url: https://codereview.chromium.org/2646463002 Cr-Commit-Position: refs/heads/master@{#42493} Committed: https://chromium.googlesource.com/v8/v8/+/76828375010edaad9504acab15799b0c7f473835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +7 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-681983.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Michael Starzinger
3 years, 11 months ago (2017-01-18 14:11:47 UTC) #5
Jarin
lgtm, thanks!
3 years, 11 months ago (2017-01-19 06:40:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646463002/1
3 years, 11 months ago (2017-01-19 09:10:12 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 09:11:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/76828375010edaad9504acab15799b0c7f4...

Powered by Google App Engine
This is Rietveld 408576698