Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2646443012: Migrate Timer to TaskRunnerTimer in TextTrackLoader (Closed)

Created:
3 years, 11 months ago by Hwanseung Lee
Modified:
3 years, 11 months ago
Reviewers:
haraken, fs
CC:
chromium-reviews, tyoshino+watch_chromium.org, nessy, gasubic, eric.carlson_apple.com, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, Nate Chapin, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate Timer to TaskRunnerTimer in TextTrackLoader Migrate Timer to TaskRunnerTimer in TextTrackLoader. TextTrackLoader is associated with networking task source. Spec that defines : https://html.spec.whatwg.org/multipage/embedded-content.html#sourcing-out-of-band-text-tracks BUG=624694 Review-Url: https://codereview.chromium.org/2646443012 Cr-Commit-Position: refs/heads/master@{#445196} Committed: https://chromium.googlesource.com/chromium/src/+/79c8fcfec38b8d2f59fa71c9a073717b37bb48ee

Patch Set 1 #

Patch Set 2 : Migrate Timer to TaskRunnerTimer in TextTrackLoader #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/core/loader/TextTrackLoader.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/TextTrackLoader.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
Hwanseung Lee
@haraken PTAL, thank you.
3 years, 11 months ago (2017-01-20 14:33:15 UTC) #4
haraken
Would you add a link to the spec in the CL description? https://html.spec.whatwg.org/multipage/embedded-content.html#sourcing-out-of-band-text-tracks Per the ...
3 years, 11 months ago (2017-01-20 16:08:45 UTC) #9
fs
On 2017/01/20 at 16:08:45, haraken wrote: > Would you add a link to the spec ...
3 years, 11 months ago (2017-01-20 16:13:15 UTC) #10
haraken
LGTM % adding a link to the spec to the CL description.
3 years, 11 months ago (2017-01-20 16:13:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646443012/40001
3 years, 11 months ago (2017-01-20 22:44:33 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 22:49:45 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/79c8fcfec38b8d2f59fa71c9a073...

Powered by Google App Engine
This is Rietveld 408576698