Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 2646443010: bluetooth: Test cancelling a Stop notify session request (Closed)

Created:
3 years, 11 months ago by ortuno
Modified:
3 years, 11 months ago
Reviewers:
scheib
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Test cancelling a Stop notify session request Adds tests for http://crrev.com/2644463005 BUG=682583 Review-Url: https://codereview.chromium.org/2646443010 Cr-Commit-Position: refs/heads/master@{#445310} Committed: https://chromium.googlesource.com/chromium/src/+/af286b82f997fada45bb41a90e6ffb6bf9d2a242

Patch Set 1 #

Patch Set 2 : Clean up #

Total comments: 2

Patch Set 3 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
ortuno
PTAL
3 years, 11 months ago (2017-01-20 02:59:29 UTC) #5
scheib
LGTM, but: https://codereview.chromium.org/2646443010/diff/20001/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc File device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc (right): https://codereview.chromium.org/2646443010/diff/20001/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc#newcode1516 device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1516: #if defined(OS_ANDROID) Why only Android?
3 years, 11 months ago (2017-01-20 18:00:59 UTC) #9
ortuno
Thanks! https://codereview.chromium.org/2646443010/diff/20001/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc File device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc (right): https://codereview.chromium.org/2646443010/diff/20001/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc#newcode1516 device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:1516: #if defined(OS_ANDROID) On 2017/01/20 at 18:00:59, scheib wrote: ...
3 years, 11 months ago (2017-01-22 23:57:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646443010/40001
3 years, 11 months ago (2017-01-22 23:57:55 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 01:28:43 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/af286b82f997fada45bb41a90e6f...

Powered by Google App Engine
This is Rietveld 408576698