Issue 2646423003: Fix regression of webview loadstart events firing for same page navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2646423003: Fix regression of webview loadstart events firing for same page navigations.

Created:
3 years, 11 months ago by jam

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix regression of webview loadstart events firing for same page navigations. This regressed in r425073 since DidStartProvisionalLoadForFrame didn't fire for same page navigations while DidStartNavigation does. BUG=680863 Review-Url: https://codereview.chromium.org/2647933002 Cr-Commit-Position: refs/heads/master@{#445150} (cherry picked from commit 840012cf9996d156f6e3286a37ca0c9d5d502edc)

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -0 lines)			Patch
M	extensions/browser/guest_view/web_view/web_view_apitest.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	extensions/browser/guest_view/web_view/web_view_guest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	extensions/test/data/web_view/apitest/guest_same_page_navigation.html	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	extensions/test/data/web_view/apitest/main.js	View	3 chunks	+25 lines, -0 lines	0 comments	Download