Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1414)

Issue 2646363003: [turbofan] Add fast path for cached property names. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add fast path for cached property names. Port the fast path for accessor inlining to cached property names from Crankshaft to TurboFan. This constant-folds accesses to document in a script. R=jochen@chromium.org BUG=v8:5548 Review-Url: https://codereview.chromium.org/2646363003 Cr-Commit-Position: refs/heads/master@{#42600} Committed: https://chromium.googlesource.com/v8/v8/+/e347408d4d4fa17ce776b866ace18f2e89744685

Patch Set 1 #

Patch Set 2 : Test from jochen. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -3 lines) Patch
M src/compiler/access-info.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-api-accessors.cc View 1 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-23 10:13:25 UTC) #1
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-23 11:38:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646363003/20001
3 years, 11 months ago (2017-01-23 11:39:45 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 12:14:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e347408d4d4fa17ce776b866ace18f2e897...

Powered by Google App Engine
This is Rietveld 408576698