Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: chrome/android/java/res/layout/clear_browsing_data_tab_content.xml

Issue 2646313005: Implement additional parts of the new ui for CBD. (Closed)
Patch Set: fix review issues Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/clear_browsing_data_tab_content.xml
diff --git a/chrome/android/java/res/layout/clear_browsing_data_tab_content.xml b/chrome/android/java/res/layout/clear_browsing_data_tab_content.xml
new file mode 100644
index 0000000000000000000000000000000000000000..9f1fb8c076e5b4873a9753c131d67f4278dcb6c8
--- /dev/null
+++ b/chrome/android/java/res/layout/clear_browsing_data_tab_content.xml
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2017 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<!-- Used by ClearBrowsingDataPreferencesTab to replace the default layout
+ of a PreferenceFragment and add a footer button. -->
+
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:orientation="vertical">
+
+ <FrameLayout
Theresa 2017/01/27 03:30:11 If you move android:layout_weight="1" ad android:l
dullweber 2017/01/30 11:36:44 yes
+ android:layout_weight="1"
+ android:layout_width="match_parent"
+ android:layout_height="0dp">
+ <ListView
+ android:id="@android:id/list"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"/>
+ </FrameLayout>
+
+ <LinearLayout
Theresa 2017/01/27 03:30:11 This should probably be a Button with style="?andr
dullweber 2017/01/30 11:36:44 Thanks, I changed the xml to be similar to the Pas
+ android:id="@+id/footer"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:gravity="center"
+ android:orientation="vertical">
+
+ <View style="@style/Divider"/>
+
+ <Button
+ android:id="@+id/clear_button"
+ style="@style/Base.Widget.AppCompat.Button.Borderless"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:text="@string/clear_data_delete"
+ android:textColor="@color/pref_accent_color" />
+ </LinearLayout>
+
+</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698