chrome/android/java/res/layout/clear_browsing_data_tab_content.xml - Issue 2646313005: Implement additional parts of the new ui for CBD.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/clear_browsing_data_tab_content.xml

Issue 2646313005: Implement additional parts of the new ui for CBD. (Closed)

Patch Set: fix review issues Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- Used by ClearBrowsingDataPreferencesTab to replace the default layout

	7 of a PreferenceFragment and add a footer button. -->

	8

	9 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	10 android:layout_width="match_parent"

	11 android:layout_height="match_parent"

	12 android:orientation="vertical">

	13

	14 <FrameLayout
	Theresa 2017/01/27 03:30:11 If you move android:layout_weight="1" ad android:l If you move android:layout_weight="1" ad android:layout_height="0dp" to the child ListView and remove this FrameLayout, does the layout look the same? dullweber 2017/01/30 11:36:44 yes Show quoted text On 2017/01/27 03:30:11, Theresa wrote: > If you move android:layout_weight="1" ad android:layout_height="0dp" to the > child ListView and remove this FrameLayout, does the layout look the same? yes
	15 android:layout_weight="1"

	16 android:layout_width="match_parent"

	17 android:layout_height="0dp">

	18 <ListView

	19 android:id="@android:id/list"

	20 android:layout_width="match_parent"

	21 android:layout_height="match_parent"/>

	22 </FrameLayout>

	23

	24 <LinearLayout
	Theresa 2017/01/27 03:30:11 This should probably be a Button with style="?andr This should probably be a Button with style="?android:attr/buttonBarButtonStyle" to match our PasswordEntryEditor which has similar (hopefully exactly the same) looking buttons. dullweber 2017/01/30 11:36:44 Thanks, I changed the xml to be similar to the Pas Show quoted text On 2017/01/27 03:30:11, Theresa wrote: > This should probably be a Button with style="?android:attr/buttonBarButtonStyle" > to match our PasswordEntryEditor which has similar (hopefully exactly the same) > looking buttons. Thanks, I changed the xml to be similar to the PasswordEntryEditor. It still looks the same
	25 android:id="@+id/footer"

	26 android:layout_width="match_parent"

	27 android:layout_height="wrap_content"

	28 android:gravity="center"

	29 android:orientation="vertical">

	30

	31 <View style="@style/Divider"/>

	32

	33 <Button

	34 android:id="@+id/clear_button"

	35 style="@style/Base.Widget.AppCompat.Button.Borderless"

	36 android:layout_width="wrap_content"

	37 android:layout_height="wrap_content"

	38 android:text="@string/clear_data_delete"

	39 android:textColor="@color/pref_accent_color" />

	40 </LinearLayout>

	41

	42 </LinearLayout>

OLD	NEW