Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: ui/display/mojo/display_snapshot_mojo.mojom

Issue 2646213002: Write mojom and StructTraits for DisplaySnapshot. (Closed)
Patch Set: fix format/comments. Refactor structure/code. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/display/mojo/display_snapshot_mojo.mojom
diff --git a/ui/display/mojo/display_snapshot_mojo.mojom b/ui/display/mojo/display_snapshot_mojo.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..44660f1beb20418f86e1b4bd81742b6cb7aa381b
--- /dev/null
+++ b/ui/display/mojo/display_snapshot_mojo.mojom
@@ -0,0 +1,31 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module display.mojom;
+
+import "mojo/common/file_path.mojom";
+import "ui/display/mojo/display_constants.mojom";
+import "ui/display/mojo/display_mode.mojom";
+import "ui/gfx/geometry/mojo/geometry.mojom";
+
+// Corresponds to display::DisplaySnapshotMojo
kylechar 2017/02/13 22:01:23 Comments should have proper punctuation, for examp
thanhph1 2017/02/14 20:20:53 Done.
+struct DisplaySnapshotMojo {
+ int64 display_id;
+ gfx.mojom.Point origin;
+ gfx.mojom.Size physical_size;
+ display.mojom.DisplayConnectionType type;
+ bool is_aspect_preserving_scaling;
+ bool has_overscan;
+ bool has_color_correction_matrix;
+ string display_name;
+ mojo.common.mojom.FilePath sys_path;
+ array<display.mojom.DisplayMode> modes;
+ array<uint8> edid;
+ uint64 current_mode_index;
+ bool current_mode_exist;
kylechar 2017/02/13 22:01:23 nit: has_current_mode
thanhph1 2017/02/14 20:20:53 Done.
+ uint64 native_mode_index;
+ bool native_mode_exist;
kylechar 2017/02/13 22:01:23 nit: has_native_mode
thanhph1 2017/02/14 20:20:53 Done.
+ int64 product_id;
+ gfx.mojom.Size maximum_cursor_size;
+};

Powered by Google App Engine
This is Rietveld 408576698