ui/display/mojo/display_snapshot_mojo.mojom - Issue 2646213002: Write mojom and StructTraits for DisplaySnapshot.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/display/mojo/display_snapshot_mojo.mojom

Issue 2646213002: Write mojom and StructTraits for DisplaySnapshot. (Closed)

Patch Set: fix format/comments. Refactor structure/code. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/display/mojo/display_snapshot_mojo.h ('K') | « ui/display/mojo/display_snapshot_mojo.h ('k') | ui/display/mojo/display_snapshot_mojo.typemap » ('j') | ui/display/mojo/display_snapshot_mojo_struct_traits.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module display.mojom;

	6

	7 import "mojo/common/file_path.mojom";

	8 import "ui/display/mojo/display_constants.mojom";

	9 import "ui/display/mojo/display_mode.mojom";

	10 import "ui/gfx/geometry/mojo/geometry.mojom";

	11

	12 // Corresponds to display::DisplaySnapshotMojo
	kylechar 2017/02/13 22:01:23 Comments should have proper punctuation, for examp Comments should have proper punctuation, for example end with a period. Please fix other comments too :) thanhph1 2017/02/14 20:20:53 Done. Show quoted text On 2017/02/13 22:01:23, kylechar wrote: > Comments should have proper punctuation, for example end with a period. Please > fix other comments too :) Done.
	13 struct DisplaySnapshotMojo {

	14 int64 display_id;

	15 gfx.mojom.Point origin;

	16 gfx.mojom.Size physical_size;

	17 display.mojom.DisplayConnectionType type;

	18 bool is_aspect_preserving_scaling;

	19 bool has_overscan;

	20 bool has_color_correction_matrix;

	21 string display_name;

	22 mojo.common.mojom.FilePath sys_path;

	23 array<display.mojom.DisplayMode> modes;

	24 array<uint8> edid;

	25 uint64 current_mode_index;

	26 bool current_mode_exist;
	kylechar 2017/02/13 22:01:23 nit: has_current_mode nit: has_current_mode thanhph1 2017/02/14 20:20:53 Done. Show quoted text On 2017/02/13 22:01:23, kylechar wrote: > nit: has_current_mode Done.
	27 uint64 native_mode_index;

	28 bool native_mode_exist;
	kylechar 2017/02/13 22:01:23 nit: has_native_mode nit: has_native_mode thanhph1 2017/02/14 20:20:53 Done. Show quoted text On 2017/02/13 22:01:23, kylechar wrote: > nit: has_native_mode Done.
	29 int64 product_id;

	30 gfx.mojom.Size maximum_cursor_size;

	31 };

OLD	NEW