Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2646193002: Replace OnConnect with OnBindInterface in //mash. (Closed)

Created:
3 years, 11 months ago by Ben Goodger (Google)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace OnConnect with OnBindInterface in //mash. R=rockot@chromium.org Review-Url: https://codereview.chromium.org/2646193002 Cr-Commit-Position: refs/heads/master@{#445850} Committed: https://chromium.googlesource.com/chromium/src/+/1bd1cf4ed15972f6510819f0d9cf62da968ef1b1

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -63 lines) Patch
M mash/browser/browser.h View 3 chunks +6 lines, -2 lines 0 comments Download
M mash/browser/browser.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M mash/catalog_viewer/catalog_viewer.h View 3 chunks +6 lines, -2 lines 0 comments Download
M mash/catalog_viewer/catalog_viewer.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M mash/example/views_examples/views_examples.cc View 4 chunks +11 lines, -5 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.h View 3 chunks +6 lines, -2 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M mash/quick_launch/quick_launch.h View 3 chunks +6 lines, -2 lines 0 comments Download
M mash/quick_launch/quick_launch.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M mash/session/session.h View 1 chunk +0 lines, -2 lines 0 comments Download
M mash/session/session.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M mash/simple_wm/simple_wm.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M mash/simple_wm/simple_wm.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M mash/task_viewer/task_viewer.h View 3 chunks +6 lines, -2 lines 0 comments Download
M mash/task_viewer/task_viewer.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M mash/webtest/webtest.h View 3 chunks +6 lines, -2 lines 0 comments Download
M mash/webtest/webtest.cc View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
Ben Goodger (Google)
Note the repetitiveness of OnBindInterface().
3 years, 11 months ago (2017-01-20 20:52:20 UTC) #3
Ken Rockot(use gerrit already)
lgtm
3 years, 11 months ago (2017-01-20 22:26:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646193002/40001
3 years, 11 months ago (2017-01-24 22:40:00 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 22:52:19 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1bd1cf4ed15972f6510819f0d9cf...

Powered by Google App Engine
This is Rietveld 408576698