Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2646163004: Add a feature to control if we drop records due to excess events. Enabled by default as this is cur… (Closed)

Created:
3 years, 11 months ago by rkaplow
Modified:
3 years, 11 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a feature to control if we drop UMA records due to excess events. Enabled by default as this is current behavior. BUG=682329 Review-Url: https://codereview.chromium.org/2646163004 Cr-Commit-Position: refs/heads/master@{#445210} Committed: https://chromium.googlesource.com/chromium/src/+/02e248436f3736e6b85ab4c47452ce13611cdd11

Patch Set 1 #

Patch Set 2 : wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M components/metrics/metrics_service.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
rkaplow
I first made a separate histogram tracking the else {} case, but that seemed like ...
3 years, 11 months ago (2017-01-20 21:45:50 UTC) #3
Alexei Svitkine (slow)
lgtm
3 years, 11 months ago (2017-01-20 21:50:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2646163004/20001
3 years, 11 months ago (2017-01-20 22:35:57 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 23:40:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/02e248436f3736e6b85ab4c47452...

Powered by Google App Engine
This is Rietveld 408576698