Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2646093003:
[wasm] Unreachability fix for br_table. (Closed)
Description[wasm] Unreachability fix for br_table.
R=rossberg@chromium.org
BUG=chromium:682659
Review-Url: https://codereview.chromium.org/2646093003
Cr-Commit-Position: refs/heads/master@{#42564}
Committed: https://chromium.googlesource.com/v8/v8/+/04434acbcea8012236fa1105076480336c00a089
Patch Set 1 #
Total comments: 1
Patch Set 2 : And throw #Patch Set 3 : [wasm] Unreachability fix for br_table. #
Messages
Total messages: 22 (14 generated)
The CQ bit was checked by titzer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2646093003/diff/1/src/wasm/function-body-deco... File src/wasm/function-body-decoder.cc (right): https://codereview.chromium.org/2646093003/diff/1/src/wasm/function-body-deco... src/wasm/function-body-decoder.cc:683: case kExprThrow: { Does this need an EndControl, too?
The CQ bit was checked by titzer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/20 13:14:29, rossberg wrote: > https://codereview.chromium.org/2646093003/diff/1/src/wasm/function-body-deco... > File src/wasm/function-body-decoder.cc (right): > > https://codereview.chromium.org/2646093003/diff/1/src/wasm/function-body-deco... > src/wasm/function-body-decoder.cc:683: case kExprThrow: { > Does this need an EndControl, too? Done.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
On 2017/01/20 13:16:51, titzer wrote: > On 2017/01/20 13:14:29, rossberg wrote: > > > https://codereview.chromium.org/2646093003/diff/1/src/wasm/function-body-deco... > > File src/wasm/function-body-decoder.cc (right): > > > > > https://codereview.chromium.org/2646093003/diff/1/src/wasm/function-body-deco... > > src/wasm/function-body-decoder.cc:683: case kExprThrow: { > > Does this need an EndControl, too? > > Done. Gonna have to undo the throw change because it turns out we are not building a proper TurboFan graph for throws and it'll take some major surgery to do so, which is best done in another CL.
The CQ bit was checked by titzer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by titzer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rossberg@chromium.org Link to the patchset: https://codereview.chromium.org/2646093003/#ps40001 (title: "[wasm] Unreachability fix for br_table.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484922638975480,
"parent_rev": "226e454069c78c4197f951b5d5d822fb412ab7e0", "commit_rev":
"04434acbcea8012236fa1105076480336c00a089"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Unreachability fix for br_table. R=rossberg@chromium.org BUG=chromium:682659 ========== to ========== [wasm] Unreachability fix for br_table. R=rossberg@chromium.org BUG=chromium:682659 Review-Url: https://codereview.chromium.org/2646093003 Cr-Commit-Position: refs/heads/master@{#42564} Committed: https://chromium.googlesource.com/v8/v8/+/04434acbcea8012236fa1105076480336c0... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/04434acbcea8012236fa1105076480336c0... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
