Implements CSSPropertyAPI for the clip-path property.

Implements CSSPropertyAPI for the clip-path property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyClipPath from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIClipPath.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIClipPath.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIClipPath.cpp, which implements CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2646043003
Cr-Commit-Position: refs/heads/master@{#444986}
Committed: https://chromium.googlesource.com/chromium/src/+/a5de67a2a364184a9e9cdfe591aa8abc28046133

[ktyliu, 2017-01-20 03:11:02]

ktyliu@chromium.org changed reviewers:
+ aazzam@google.com

[aazzam, 2017-01-20 03:15:55]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-01-20 03:15:56]

lgtm + comment, sasha please see the comment below :)

https://codereview.chromium.org/2646043003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp
(right):

https://codereview.chromium.org/2646043003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp:13:
using namespace CSSPropertyParserHelpers;
I'm not sure if our style conventions prefer using "using namespace", or just
referring to the functions as CSSPropertyParserHelpers::...()
Added sasha to check :)

[ktyliu, 2017-01-20 03:18:41]

thanks for the quick review

https://codereview.chromium.org/2646043003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp
(right):

https://codereview.chromium.org/2646043003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp:13:
using namespace CSSPropertyParserHelpers;
On 2017/01/20 at 03:15:56, aazzam wrote:
> I'm not sure if our style conventions prefer using "using namespace", or just
referring to the functions as CSSPropertyParserHelpers::...()
> Added sasha to check :)

I am happy either way.
Fwiw, I originally didn't have the "using ..." but found that I need it in two
places -- consumeUrl and consumeIdent. Having it in consumeUrl (within if and
assignment) doesn't look terribly pretty so I went with "using ..."

[sashab, 2017-01-20 03:46:48]

LGTM thanks kevin

https://codereview.chromium.org/2646043003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp
(right):

https://codereview.chromium.org/2646043003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp:13:
using namespace CSSPropertyParserHelpers;
On 2017/01/20 at 03:18:41, ktyliu wrote:
> On 2017/01/20 at 03:15:56, aazzam wrote:
> > I'm not sure if our style conventions prefer using "using namespace", or
just referring to the functions as CSSPropertyParserHelpers::...()
> > Added sasha to check :)
> 
> I am happy either way.
> Fwiw, I originally didn't have the "using ..." but found that I need it in two
places -- consumeUrl and consumeIdent. Having it in consumeUrl (within if and
assignment) doesn't look terribly pretty so I went with "using ..."

Huh, I totally forgot about 'using namespace'... Umm we haven't used it in any
of the other API files, so for consistency let's leave it out. I don't think we
use it much in blink anyway (codesearch found 5k results but they are mainly
actual namespaces like v8, std, etc -
https://cs.chromium.org/search/?q=%22using+namespace%22&sq=package:chromium&t...)
and at some point I think we're gonna change CSSPropertyParserHelpers to not be
a namespace, so its more futureproof without it. :^)

[ktyliu, 2017-01-20 03:53:44]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[ktyliu, 2017-01-20 03:53:59]

https://codereview.chromium.org/2646043003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp
(right):

https://codereview.chromium.org/2646043003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIClipPath.cpp:13:
using namespace CSSPropertyParserHelpers;
Done.

Sounds good to be consistent :)

[commit-bot: I haz the power, 2017-01-20 03:54:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 05:28:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 05:28:51]

Dry run: This issue passed the CQ dry run.

[ktyliu, 2017-01-20 05:30:10]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-20 05:30:10]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
aazzam@google.com
Link to the patchset: https://codereview.chromium.org/2646043003/#ps20001
(title: "remove using namespace")

[commit-bot: I haz the power, 2017-01-20 05:30:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 05:33:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484890210094240,
"parent_rev": "14031399407b60aa7cfa33673b6aa3a2ddb46fa8", "commit_rev":
"a5de67a2a364184a9e9cdfe591aa8abc28046133"}

[commit-bot: I haz the power, 2017-01-20 05:34:30]

Description was changed from

==========
Implements CSSPropertyAPI for the clip-path property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyClipPath from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIClipPath.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIClipPath.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIClipPath.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the clip-path property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyClipPath from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIClipPath.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIClipPath.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIClipPath.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2646043003
Cr-Commit-Position: refs/heads/master@{#444986}
Committed:
https://chromium.googlesource.com/chromium/src/+/a5de67a2a364184a9e9cdfe591aa...
==========

[commit-bot: I haz the power, 2017-01-20 05:34:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a5de67a2a364184a9e9cdfe591aa...