Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 264603002: Cleanup of SSE optimization files. (Closed)

Created:
6 years, 7 months ago by henrik.smiding
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com, caryclark, borenet
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Cleanup of SSE optimization files. General cleanup of optimization files for x86/SSEx. Renamed the opts_check_SSE2.cpp file to _x86, since it's not specific to SSE2. Commented out the ColorRect32 optimization, since it's disabled anyway, to make it more visible. Also fixed a lot of indentation, inclusion guards, spelling, copyright headers, braces, whitespace, and sorting of includes. Author: henrik.smiding@intel.com Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>; Committed: http://code.google.com/p/skia/source/detail?r=14464

Patch Set 1 #

Patch Set 2 : Improved ColorRect32 comment #

Patch Set 3 : Added chromium sync patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+524 lines, -837 lines) Patch
M gyp/opts.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcState_matrixProcs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkBitmapFilter_opts_SSE2.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/opts/SkBitmapFilter_opts_SSE2.cpp View 6 chunks +395 lines, -398 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSE2.h View 3 chunks +7 lines, -4 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSE2.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSSE3.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSSE3.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/opts/SkBlitRect_opts_SSE2.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/opts/SkBlitRect_opts_SSE2.cpp View 2 chunks +10 lines, -11 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE2.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/opts/SkBlitRow_opts_SSE2.cpp View 5 chunks +5 lines, -8 lines 0 comments Download
M src/opts/SkBlurImage_opts_SSE2.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/opts/SkBlurImage_opts_SSE2.cpp View 1 chunk +10 lines, -15 lines 0 comments Download
M src/opts/SkMorphology_opts_SSE2.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/opts/SkMorphology_opts_SSE2.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M src/opts/SkUtils_opts_SSE2.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/opts/SkUtils_opts_SSE2.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/opts/SkXfermode_opts_SSE2.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/opts/SkXfermode_opts_SSE2.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
D src/opts/opts_check_SSE2.cpp View 1 chunk +0 lines, -358 lines 0 comments Download
A + src/opts/opts_check_x86.cpp View 1 13 chunks +40 lines, -19 lines 0 comments Download
M tools/chromium/chrome_changes View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
henrik.smiding
This is a first step in cleanup of x86 optimization files.
6 years, 7 months ago (2014-04-30 09:50:04 UTC) #1
mtklein
Yeesh, how sloppy. Thank you! LGTM
6 years, 7 months ago (2014-04-30 11:02:40 UTC) #2
mtklein
Before submitting this to the CQ, can you please add https://codereview.chromium.org/265513005/ to tools/chromium/chrome_changes ? This ...
6 years, 7 months ago (2014-04-30 11:15:59 UTC) #3
henrik.smiding
On 2014/04/30 11:15:59, mtklein wrote: > Before submitting this to the CQ, can you please ...
6 years, 7 months ago (2014-04-30 14:49:20 UTC) #4
henrik.smiding
The CQ bit was checked by henrik.smiding@intel.com
6 years, 7 months ago (2014-04-30 14:50:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/henrik.smiding@intel.com/264603002/40001
6 years, 7 months ago (2014-04-30 14:51:00 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 14:59:09 UTC) #7
Message was sent while issue was closed.
Change committed as 14464

Powered by Google App Engine
This is Rietveld 408576698