Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Issue 2645973005: Coordinators: let the presenting view controller dismiss. (Closed)

Created:
3 years, 11 months ago by lpromero
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, pkl (ping after 24h if needed), gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, lpromero+watch_chromium.org, sebsg+paymentswatch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Coordinators: let the presenting view controller dismiss. The view controller to dismiss is the presented view controller, so dismissViewController needs to be called on its presenting view controller. Otherwise if the presented has itself presented something, it will just dismiss its own presented and not get dismissed. BUG=none R=marq@chromium.org Review-Url: https://codereview.chromium.org/2645973005 Cr-Commit-Position: refs/heads/master@{#445685} Committed: https://chromium.googlesource.com/chromium/src/+/225bd1fd50ad1fb63e9175e173b9d5fdc06ed081

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M ios/chrome/browser/payments/payment_request_coordinator.mm View 1 chunk +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/loading_alert_coordinator.mm View 1 chunk +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/elements/selector_coordinator.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/settings/settings_coordinator.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab/tab_coordinator.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/tab_strip/tab_strip_container_coordinator.mm View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/tools/tools_coordinator.mm View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
lpromero
3 years, 11 months ago (2017-01-20 15:51:15 UTC) #1
marq (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-23 15:21:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645973005/1
3 years, 11 months ago (2017-01-23 16:04:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/353053)
3 years, 11 months ago (2017-01-23 16:05:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645973005/20001
3 years, 11 months ago (2017-01-24 08:48:19 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 08:58:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/225bd1fd50ad1fb63e9175e173b9...

Powered by Google App Engine
This is Rietveld 408576698