Use control clip rather than overflow clip when present for PaintLayers.

Use control clip rather than overflow clip when present for PaintLayers.

BUG=682574
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2645963003
Cr-Commit-Position: refs/heads/master@{#445182}
Committed: https://chromium.googlesource.com/chromium/src/+/b281bde16d4878454ed00e1335c80100c414a920

[chrishtr, 2017-01-19 23:07:00]

Description was changed from

==========
none


none


none


none

BUG=
==========

to

==========
none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-19 23:08:20]

Description was changed from

==========
none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use control clip rather than overflow clip when present for PaintLayers.

BUG=682574
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-19 23:08:32]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 23:09:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 01:15:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 01:15:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-01-20 19:13:55]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2017-01-20 19:17:35]

LGTM

https://codereview.chromium.org/2645963003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right):

https://codereview.chromium.org/2645963003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:98: ClipRect
newOverflowClip = overflowOrControlClip(
Can you make the same change in PaintPropertyTreeBuilder::updateOverflowClip?

[pdr., 2017-01-20 19:17:36]

LGTM

https://codereview.chromium.org/2645963003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right):

https://codereview.chromium.org/2645963003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:98: ClipRect
newOverflowClip = overflowOrControlClip(
Can you make the same change in PaintPropertyTreeBuilder::updateOverflowClip?

[chrishtr, 2017-01-20 19:43:17]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-01-20 19:43:17]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2645963003/#ps40001
(title: "none")

[commit-bot: I haz the power, 2017-01-20 19:43:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 21:45:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 21:45:06]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[pdr., 2017-01-20 22:12:22]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-01-20 22:13:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 22:17:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484950342699650,
"parent_rev": "5ebd744f9c4619ada853a2fdf6b6cdafd30f4c49", "commit_rev":
"b281bde16d4878454ed00e1335c80100c414a920"}

[commit-bot: I haz the power, 2017-01-20 22:18:30]

Description was changed from

==========
Use control clip rather than overflow clip when present for PaintLayers.

BUG=682574
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use control clip rather than overflow clip when present for PaintLayers.

BUG=682574
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2645963003
Cr-Commit-Position: refs/heads/master@{#445182}
Committed:
https://chromium.googlesource.com/chromium/src/+/b281bde16d4878454ed00e1335c8...
==========

[commit-bot: I haz the power, 2017-01-20 22:18:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b281bde16d4878454ed00e1335c8...

[chrishtr, 2017-01-20 22:51:10]

https://codereview.chromium.org/2645963003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp (right):

https://codereview.chromium.org/2645963003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp:98: ClipRect
newOverflowClip = overflowOrControlClip(
On 2017/01/20 at 19:17:36, pdr. wrote:
> Can you make the same change in PaintPropertyTreeBuilder::updateOverflowClip?

Added a TODO. Will do this in another CL because this fixes an M57 regression
and so needs
to be cherrypicked.