Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: pkg/dev_compiler/tool/build_sdk.dart

Issue 2645953006: Hard fail on ddc sdk build error (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/dev_compiler/tool/build_sdk.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/tool/build_sdk.dart
diff --git a/pkg/dev_compiler/tool/build_sdk.dart b/pkg/dev_compiler/tool/build_sdk.dart
index 99d84e7240f77b74e342725febe8996d995aa406..91812eec3b212641adbe1eb33d12f2e770742bed 100644
--- a/pkg/dev_compiler/tool/build_sdk.dart
+++ b/pkg/dev_compiler/tool/build_sdk.dart
@@ -51,5 +51,8 @@ main(List<String> arguments) {
'dart:web_gl',
'dart:web_sql'
]);
- compile(args);
+
+ if (compile(args) != 0) {
+ throw 'SDK build failed.';
Jennifer Messerly 2017/01/21 00:55:27 you don't need a throw. You can just return here,
+ }
}
« no previous file with comments | « no previous file | pkg/dev_compiler/tool/build_sdk.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698