Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 #!/usr/bin/env dart | 1 #!/usr/bin/env dart |
| 2 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file | 2 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file |
| 3 // for details. All rights reserved. Use of this source code is governed by a | 3 // for details. All rights reserved. Use of this source code is governed by a |
| 4 // BSD-style license that can be found in the LICENSE file. | 4 // BSD-style license that can be found in the LICENSE file. |
| 5 | 5 |
| 6 /// A straightforward script that builds the SDK. | 6 /// A straightforward script that builds the SDK. |
| 7 /// | 7 /// |
| 8 /// This would be easy enough to do in a shell script, as we go through the | 8 /// This would be easy enough to do in a shell script, as we go through the |
| 9 /// command line interface. But being able to build from a Dart library means | 9 /// command line interface. But being able to build from a Dart library means |
| 10 /// we can call this during code coverage to get more realistic numbers. | 10 /// we can call this during code coverage to get more realistic numbers. |
| (...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 44 'dart:mirrors', | 44 'dart:mirrors', |
| 45 'dart:typed_data', | 45 'dart:typed_data', |
| 46 'dart:indexed_db', | 46 'dart:indexed_db', |
| 47 'dart:html', | 47 'dart:html', |
| 48 'dart:html_common', | 48 'dart:html_common', |
| 49 'dart:svg', | 49 'dart:svg', |
| 50 'dart:web_audio', | 50 'dart:web_audio', |
| 51 'dart:web_gl', | 51 'dart:web_gl', |
| 52 'dart:web_sql' | 52 'dart:web_sql' |
| 53 ]); | 53 ]); |
| 54 compile(args); | 54 |
| 55 if (compile(args) != 0) { | |
| 56 throw 'SDK build failed.'; | |
|
Jennifer Messerly
2017/01/21 00:55:27
you don't need a throw. You can just return here,
| |
| 57 } | |
| 55 } | 58 } |
| OLD | NEW |