Hard fail on ddc sdk build error

Hard fail on ddc sdk build error

R=jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/fa2823925b8ec81e33121ea077db7f375e0798bc

[vsm, 2017-01-20 23:53:17]

vsm@google.com changed reviewers:
+ jacobr@google.com, leafp@google.com

[Jacob, 2017-01-20 23:54:17]

lgtm

[vsm, 2017-01-20 23:55:32]

Description was changed from

==========
Hard fail on ddc sdk build error
==========

to

==========
Hard fail on ddc sdk build error

R=jacobr@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fa2823925b8ec81e33121ea077db7f375e0798bc
==========

[vsm, 2017-01-20 23:55:34]

Committed patchset #1 (id:1) manually as
fa2823925b8ec81e33121ea077db7f375e0798bc (presubmit successful).

[Jennifer Messerly, 2017-01-21 00:55:27]

jmesserly@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2017-01-21 00:55:27]

https://codereview.chromium.org/2645953006/diff/1/pkg/dev_compiler/tool/build...
File pkg/dev_compiler/tool/build_sdk.dart (right):

https://codereview.chromium.org/2645953006/diff/1/pkg/dev_compiler/tool/build...
pkg/dev_compiler/tool/build_sdk.dart:56: throw 'SDK build failed.';
you don't need a throw. You can just return here, that will set the exit code.

The lack of "return" was most likely an oversight.

[vsm, 2017-01-21 01:05:55]

On 2017/01/21 00:55:27, Jennifer Messerly wrote:
>
https://codereview.chromium.org/2645953006/diff/1/pkg/dev_compiler/tool/build...
> File pkg/dev_compiler/tool/build_sdk.dart (right):
> 
>
https://codereview.chromium.org/2645953006/diff/1/pkg/dev_compiler/tool/build...
> pkg/dev_compiler/tool/build_sdk.dart:56: throw 'SDK build failed.';
> you don't need a throw. You can just return here, that will set the exit code.
> 
> The lack of "return" was most likely an oversight.

That's what I tried first, but it didn't seem to work.  Will try again.

[Jennifer Messerly, 2017-01-21 02:17:38]

On 2017/01/21 01:05:55, vsm wrote:
> On 2017/01/21 00:55:27, Jennifer Messerly wrote:
> >
>
https://codereview.chromium.org/2645953006/diff/1/pkg/dev_compiler/tool/build...
> > File pkg/dev_compiler/tool/build_sdk.dart (right):
> > 
> >
>
https://codereview.chromium.org/2645953006/diff/1/pkg/dev_compiler/tool/build...
> > pkg/dev_compiler/tool/build_sdk.dart:56: throw 'SDK build failed.';
> > you don't need a throw. You can just return here, that will set the exit
code.
> > 
> > The lack of "return" was most likely an oversight.
> 
> That's what I tried first, but it didn't seem to work.  Will try again.

exit(code) also works.