[async-iteration] expose Symbol.asyncIterator behind flag --harmony-async-iteration

[async-iteration] expose Symbol.asyncIterator behind flag --harmony-async-iteration

Flag is used by followup patches split apart from
https://codereview.chromium.org/2622833002/, and tests for each split
out CL ends up using Symbol.asyncIterator, so it makes sense to land it
first (behind a flag).

BUG=v8:5855
R=littledan@chromium.org, adamk@chromium.org

Review-Url: https://codereview.chromium.org/2645923003
Cr-Commit-Position: refs/heads/master@{#42527}
Committed: https://chromium.googlesource.com/v8/v8/+/498084222a9ead2af42e95bb463614f0b8e6b1d7

[caitp, 2017-01-19 21:25:33]

The CQ bit was checked by caitp@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 21:25:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caitp, 2017-01-19 21:51:33]

Hi, PTAL --- this is really tiny.

The justification for splitting this tiny piece out is included in the
description

[Dan Ehrenberg, 2017-01-19 21:55:25]

lgtm

Nit: What if the patches were checked in beginning with [async-iteration]? We
don't actually know if this feature will make it into ES2017. Alternatively
[es-next].

https://codereview.chromium.org/2645923003/diff/1/test/mjsunit/harmony/symbol...
File test/mjsunit/harmony/symbol-async-iterator.js (right):

https://codereview.chromium.org/2645923003/diff/1/test/mjsunit/harmony/symbol...
test/mjsunit/harmony/symbol-async-iterator.js:1: // Copyright 2017 the V8
project authors. All rights reserved.
Would it work to write this as a test262 test instad?

[caitp, 2017-01-19 21:56:37]

Description was changed from

==========
[es2017] expose Symbol.asyncIterator behind flag --harmony-async-iteration

Flag is used by followup patches split apart from
https://codereview.chromium.org/2622833002/, and tests for each split
out CL ends up using Symbol.asyncIterator, so it makes sense to land it
first (behind a flag).

BUG=v8:5855
R=littledan@chromium.org, adamk@chromium.org
==========

to

==========
[async-iteration] expose Symbol.asyncIterator behind flag
--harmony-async-iteration

Flag is used by followup patches split apart from
https://codereview.chromium.org/2622833002/, and tests for each split
out CL ends up using Symbol.asyncIterator, so it makes sense to land it
first (behind a flag).

BUG=v8:5855
R=littledan@chromium.org, adamk@chromium.org
==========

[caitp, 2017-01-19 21:58:38]

fixed the subject line

https://codereview.chromium.org/2645923003/diff/1/test/mjsunit/harmony/symbol...
File test/mjsunit/harmony/symbol-async-iterator.js (right):

https://codereview.chromium.org/2645923003/diff/1/test/mjsunit/harmony/symbol...
test/mjsunit/harmony/symbol-async-iterator.js:1: // Copyright 2017 the V8
project authors. All rights reserved.
On 2017/01/19 21:55:25, Dan Ehrenberg wrote:
> Would it work to write this as a test262 test instad?

I mentioned this offline, but:

I believe this test has already been written by one of those other contributors,
but is not upstream yet, and I have no idea when it will be upstream. So in the
interest of not waiting for them, there's a simple test here.

We can get rid of it after a test262 roll that includes a duplicate test

[commit-bot: I haz the power, 2017-01-19 22:03:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 22:03:23]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2017-01-19 22:04:04]

lgtm

OK, seems good to commit then. With this trivial test, the duplication seems
fine, but if you find yourself blocked on/duplicating non-trivial tests, then we
should figure out how to avoid that.

[caitp, 2017-01-19 22:06:50]

The CQ bit was checked by caitp@igalia.com

[commit-bot: I haz the power, 2017-01-19 22:06:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 23:21:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 23:21:07]

Failed to apply patch for src/flag-definitions.h:
While running git apply --index -p1;
  error: patch failed: src/flag-definitions.h:193
  error: src/flag-definitions.h: patch does not apply

Patch:       src/flag-definitions.h
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
e3390ee3d4751f07e53cac48d7c0f228b32c06ea..121f355e6bea1ab2292202af09b373f318921b86
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -193,16 +193,17 @@ DEFINE_IMPLICATION(es_staging, harmony_regexp_lookbehind)
 DEFINE_IMPLICATION(es_staging, move_object_start)
 
 // Features that are still work in progress (behind individual flags).
-#define HARMONY_INPROGRESS(V)                                           \
-  V(harmony_array_prototype_values, "harmony Array.prototype.values")   \
-  V(harmony_function_sent, "harmony function.sent")                     \
-  V(harmony_sharedarraybuffer, "harmony sharedarraybuffer")             \
-  V(harmony_simd, "harmony simd")                                       \
-  V(harmony_do_expressions, "harmony do-expressions")                   \
-  V(harmony_regexp_named_captures, "harmony regexp named captures")     \
-  V(harmony_regexp_property, "harmony unicode regexp property classes") \
-  V(harmony_class_fields, "harmony public fields in class literals")    \
-  V(harmony_object_rest_spread, "harmony object rest spread properties")
+#define HARMONY_INPROGRESS(V)                                            \
+  V(harmony_array_prototype_values, "harmony Array.prototype.values")    \
+  V(harmony_function_sent, "harmony function.sent")                      \
+  V(harmony_sharedarraybuffer, "harmony sharedarraybuffer")              \
+  V(harmony_simd, "harmony simd")                                        \
+  V(harmony_do_expressions, "harmony do-expressions")                    \
+  V(harmony_regexp_named_captures, "harmony regexp named captures")      \
+  V(harmony_regexp_property, "harmony unicode regexp property classes")  \
+  V(harmony_class_fields, "harmony public fields in class literals")     \
+  V(harmony_object_rest_spread, "harmony object rest spread properties") \
+  V(harmony_async_iteration, "harmony async iteration")
 
 // Features that are complete (but still behind --harmony/es-staging flag).
 #define HARMONY_STAGED_BASE(V)                              \

[caitp, 2017-01-20 00:04:59]

The CQ bit was checked by caitp@igalia.com

[caitp, 2017-01-20 00:04:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/2645923003/#ps20001
(title: "for landing")

[commit-bot: I haz the power, 2017-01-20 00:05:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 00:42:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484870699540600,
"parent_rev": "5587c476a11604f4e60cac2f85a04383b20fabaf", "commit_rev":
"498084222a9ead2af42e95bb463614f0b8e6b1d7"}

[commit-bot: I haz the power, 2017-01-20 00:42:16]

Description was changed from

==========
[async-iteration] expose Symbol.asyncIterator behind flag
--harmony-async-iteration

Flag is used by followup patches split apart from
https://codereview.chromium.org/2622833002/, and tests for each split
out CL ends up using Symbol.asyncIterator, so it makes sense to land it
first (behind a flag).

BUG=v8:5855
R=littledan@chromium.org, adamk@chromium.org
==========

to

==========
[async-iteration] expose Symbol.asyncIterator behind flag
--harmony-async-iteration

Flag is used by followup patches split apart from
https://codereview.chromium.org/2622833002/, and tests for each split
out CL ends up using Symbol.asyncIterator, so it makes sense to land it
first (behind a flag).

BUG=v8:5855
R=littledan@chromium.org, adamk@chromium.org

Review-Url: https://codereview.chromium.org/2645923003
Cr-Commit-Position: refs/heads/master@{#42527}
Committed:
https://chromium.googlesource.com/v8/v8/+/498084222a9ead2af42e95bb463614f0b8e...
==========

[commit-bot: I haz the power, 2017-01-20 00:42:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/498084222a9ead2af42e95bb463614f0b8e...