Cleanup mojo-js tests.

Cleanup mojo-js tests.

1. Moves unittests to mojo/public/js where rest of the unittests
   are located. Once we make the switch to WebIDL-based core
   bindings, these tests will run as layout tests.
2. Deletes redundant mojo/edk/test directory
3. Cleanup test targets

BUG=647036
Review-Url: https://codereview.chromium.org/2645873003
Cr-Commit-Position: refs/heads/master@{#445149}
Committed: https://chromium.googlesource.com/chromium/src/+/210e57b2b6905394ab9088be32153148309aee8c

[alokp, 2017-01-19 19:19:56]

The CQ bit was checked by alokp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 19:20:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alokp, 2017-01-19 19:21:37]

alokp@chromium.org changed reviewers:
+ yzshen@chromium.org

[yzshen1, 2017-01-19 19:48:47]

LGTM with two nits.

https://codereview.chromium.org/2645873003/diff/40001/mojo/edk/js/tests/run_j...
File mojo/edk/js/tests/run_js_unittests.cc (right):

https://codereview.chromium.org/2645873003/diff/40001/mojo/edk/js/tests/run_j...
mojo/edk/js/tests/run_js_unittests.cc:47: TEST(JSTest, core) {
Now that you are here, please change the test name to have the same format
("core" -> "Core", etc.)

https://codereview.chromium.org/2645873003/diff/40001/mojo/public/js/binding_...
File mojo/public/js/binding_tests.js (right):

https://codereview.chromium.org/2645873003/diff/40001/mojo/public/js/binding_...
mojo/public/js/binding_tests.js:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
Does it make sense to create a mojo/public/js/bindings/tests subfolder and move
these tests there?

[alokp, 2017-01-19 22:32:15]

https://codereview.chromium.org/2645873003/diff/40001/mojo/edk/js/tests/run_j...
File mojo/edk/js/tests/run_js_unittests.cc (right):

https://codereview.chromium.org/2645873003/diff/40001/mojo/edk/js/tests/run_j...
mojo/edk/js/tests/run_js_unittests.cc:47: TEST(JSTest, core) {
On 2017/01/19 19:48:47, yzshen1 wrote:
> Now that you are here, please change the test name to have the same format
> ("core" -> "Core", etc.)

Done.

https://codereview.chromium.org/2645873003/diff/40001/mojo/public/js/binding_...
File mojo/public/js/binding_tests.js (right):

https://codereview.chromium.org/2645873003/diff/40001/mojo/public/js/binding_...
mojo/public/js/binding_tests.js:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
On 2017/01/19 19:48:47, yzshen1 wrote:
> Does it make sense to create a mojo/public/js/bindings/tests subfolder and
move
> these tests there?

Yes it does. Do you think it is worth making the filenames consistent as well?
_unittests.js vs _tests.js?

[yzshen1, 2017-01-19 22:32:53]

still LGTM

https://codereview.chromium.org/2645873003/diff/40001/mojo/public/js/binding_...
File mojo/public/js/binding_tests.js (right):

https://codereview.chromium.org/2645873003/diff/40001/mojo/public/js/binding_...
mojo/public/js/binding_tests.js:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
On 2017/01/19 22:32:15, alokp wrote:
> On 2017/01/19 19:48:47, yzshen1 wrote:
> > Does it make sense to create a mojo/public/js/bindings/tests subfolder and
> move
> > these tests there?
> 
> Yes it does. Do you think it is worth making the filenames consistent as well?
> _unittests.js vs _tests.js?

That sounds good to me. Thanks!

[alokp, 2017-01-19 22:51:29]

The CQ bit was checked by alokp@chromium.org

[alokp, 2017-01-19 22:51:29]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2645873003/#ps100001
(title: "moves test files")

[commit-bot: I haz the power, 2017-01-19 22:52:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 01:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 01:59:19]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alokp, 2017-01-20 05:00:11]

The CQ bit was checked by alokp@chromium.org

[alokp, 2017-01-20 05:00:11]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2645873003/#ps120001
(title: "fixes data entries")

[commit-bot: I haz the power, 2017-01-20 05:00:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 07:20:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 07:20:24]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alokp, 2017-01-20 18:48:40]

The CQ bit was checked by alokp@chromium.org

[alokp, 2017-01-20 18:48:41]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2645873003/#ps140001
(title: "more deps fixes")

[commit-bot: I haz the power, 2017-01-20 18:48:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 20:36:30]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1484938120799400,
"parent_rev": "bfee22ef3c7c2749538912889b26c1142530a122", "commit_rev":
"210e57b2b6905394ab9088be32153148309aee8c"}

[commit-bot: I haz the power, 2017-01-20 20:37:55]

Description was changed from

==========
Cleanup mojo-js tests.

1. Moves unittests to mojo/public/js where rest of the unittests
   are located. Once we make the switch to WebIDL-based core
   bindings, these tests will run as layout tests.
2. Deletes redundant mojo/edk/test directory
3. Cleanup test targets

BUG=647036
==========

to

==========
Cleanup mojo-js tests.

1. Moves unittests to mojo/public/js where rest of the unittests
   are located. Once we make the switch to WebIDL-based core
   bindings, these tests will run as layout tests.
2. Deletes redundant mojo/edk/test directory
3. Cleanup test targets

BUG=647036

Review-Url: https://codereview.chromium.org/2645873003
Cr-Commit-Position: refs/heads/master@{#445149}
Committed:
https://chromium.googlesource.com/chromium/src/+/210e57b2b6905394ab9088be3215...
==========

[commit-bot: I haz the power, 2017-01-20 20:37:57]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/210e57b2b6905394ab9088be3215...

[Wez, 2017-02-08 17:56:33]

Description was changed from

==========
Cleanup mojo-js tests.

1. Moves unittests to mojo/public/js where rest of the unittests
   are located. Once we make the switch to WebIDL-based core
   bindings, these tests will run as layout tests.
2. Deletes redundant mojo/edk/test directory
3. Cleanup test targets

BUG=647036

Review-Url: https://codereview.chromium.org/2645873003
Cr-Commit-Position: refs/heads/master@{#445149}
Committed:
https://chromium.googlesource.com/chromium/src/+/210e57b2b6905394ab9088be3215...
==========

to

==========
Cleanup mojo-js tests.

1. Moves unittests to mojo/public/js where rest of the unittests
   are located. Once we make the switch to WebIDL-based core
   bindings, these tests will run as layout tests.
2. Deletes redundant mojo/edk/test directory
3. Cleanup test targets

BUG=647036

Review-Url: https://codereview.chromium.org/2645873003
Cr-Commit-Position: refs/heads/master@{#445149}
Committed:
https://chromium.googlesource.com/chromium/src/+/210e57b2b6905394ab9088be3215...
==========

[Wez, 2017-02-08 17:56:33]

wez@chromium.org changed reviewers:
+ dpranke@chromium.org

[Wez, 2017-02-08 17:59:13]

Hallo dpranke@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective review from you:
	testing/buildbot/gn_isolate_map.pyl
Thanks,
Wez

[Dirk Pranke, 2017-02-08 18:21:36]

lgtm