Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2645793002: Revert of Fix for fullscreen layout timing on Galaxy devices. (Closed)

Created:
3 years, 11 months ago by bokan
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix for fullscreen layout timing on Galaxy devices. (patchset #2 id:20001 of https://codereview.chromium.org/2635563002/ ) Reason for revert: Fullscreen tests breaking on Clank builders. BUG=682353 Original issue's description: > Fix for fullscreen layout timing on Galaxy devices. > > Remove the requestLayout call in enterFullscreen > > BUG=676634 > > Review-Url: https://codereview.chromium.org/2635563002 > Cr-Commit-Position: refs/heads/master@{#444352} > Committed: https://chromium.googlesource.com/chromium/src/+/8e1c144ac1b517fb8406a3a3d17e9b3ed3aeb911 TBR=tedchoc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=676634 Review-Url: https://codereview.chromium.org/2645793002 Cr-Commit-Position: refs/heads/master@{#444623} Committed: https://chromium.googlesource.com/chromium/src/+/0c8ae63da637ec94525728b9bb256ba475056e49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
bokan
Created Revert of Fix for fullscreen layout timing on Galaxy devices.
3 years, 11 months ago (2017-01-19 03:27:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645793002/1
3 years, 11 months ago (2017-01-19 03:28:19 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 03:29:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c8ae63da637ec94525728b9bb25...

Powered by Google App Engine
This is Rietveld 408576698