Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2645783002: Replaced webControllerWebProcessDidCrash: with RenderProcessGone. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced webControllerWebProcessDidCrash: with RenderProcessGone. webControllerWebProcessDidCrash: is a deprecated method from CRWWebDelegate protocol. RenderProcessGone mirrors WebContentsDelegate method with the same name. BUG=674991 Review-Url: https://codereview.chromium.org/2645783002 Cr-Commit-Position: refs/heads/master@{#444750} Committed: https://chromium.googlesource.com/chromium/src/+/17c4a6c7ae7563f44594e6fd509f78bcd3d42323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -14 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_state/ui/crw_web_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/web/public/web_state/web_state_observer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/web_state/web_state_observer_bridge.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +1 line, -3 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 chunk +20 lines, -7 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_observer_bridge.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-19 01:56:14 UTC) #6
marq (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-19 09:56:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645783002/1
3 years, 11 months ago (2017-01-19 16:03:10 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 16:09:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17c4a6c7ae7563f44594e6fd509f...

Powered by Google App Engine
This is Rietveld 408576698