Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2645753002:
[Android] Simplify date format in certificate viewer (Closed)
Description[Android] Simplify date format in certificate viewer
Before this CL, the dates in the certificate viewer were displayed using only
numbers.
This can be confusing to the end user, since the ordering of date and month
depends on the current device locale. For example, 10/9/17 can mean 9 Oct 2017
or 10 Sep 2017.
This CL changes it to a format where the month is written with words, such as 10
Sep 2017. This is consistent with other parts of Chrome where we display dates,
such as the messages around displaying offline pages in the popup menu with site
information.
See the bug for screenshot of before and after.
BUG=682474
Review-Url: https://codereview.chromium.org/2645753002
Cr-Commit-Position: refs/heads/master@{#447373}
Committed: https://chromium.googlesource.com/chromium/src/+/964e9655f9b576d009c0558facdbca3154f1ab09
Patch Set 1 #
Messages
Total messages: 22 (10 generated)
Description was changed from ========== Cert BUG= ========== to ========== (Android) Changing date format in Cert. Viewer to clear and consistent one BUG=682474 ==========
marcin@mwiacek.com changed reviewers: + nyquist@chromium.org
Description was changed from ========== (Android) Changing date format in Cert. Viewer to clear and consistent one BUG=682474 ========== to ========== (Android) Changing date format in Cert. Viewer to clear and consistent one BUG=682474 (contains screenshot) ==========
Let's do the discussion on the bug first.
On 2017/01/19 00:22:57, nyquist wrote: > Let's do the discussion on the bug first. Thank you, Bug was opened on 19 Jan. Up to now nobody decided if in fact trivial change is OK or not. Is it possible to speed it up?
On 2017/01/26 10:51:16, marcin wrote: > On 2017/01/19 00:22:57, nyquist wrote: > > Let's do the discussion on the bug first. > > Thank you, > > Bug was opened on 19 Jan. Up to now nobody decided if in fact trivial change is > OK or not. Is it possible to speed it up? It seems like most of your bugs are already under consideration. Changing the UI requires approval from people who own the surface in question, so it's better to ensure that all the necessary discussion happen on the bug.
marcin@mwiacek.com changed reviewers: + lgarron@chromium.org
> It seems like most of your bugs are already under consideration. Changing the UI > requires approval from people who own the surface in question, so it's better to > ensure that all the necessary discussion happen on the bug. it looks, that I have positive opinion in the bug. Can I ask for LGTM or is bug info not clear yet ?
nyquist@chromium.org changed reviewers: + rsleevi@chromium.org
Could you update the CL description to be a bit clearer? One paragraph for answers to each of the following questions is usually helpful: - What happened before this CL? - Why was that bad? - How does this CL make it better?
Description was changed from ========== (Android) Changing date format in Cert. Viewer to clear and consistent one BUG=682474 (contains screenshot) ========== to ========== (Android) Changing date format in Cert. Viewer to clear and consistent one Before change dates in certificate viewer are written using numbers only and sometimes it isn't clear, what they mean (for example 10/9/17 can mean 9 Oct 2017 or 10 Sep 2017). Patch changes to it to format, where month is written with words. Format is consistent for example with message about displaying offline page (in popup menu with site info). BUG=682474 (contains screenshot) ==========
On 2017/01/31 18:48:10, nyquist wrote: > Could you update the CL description to be a bit clearer? > > One paragraph for answers to each of the following questions is usually helpful: > - What happened before this CL? > - Why was that bad? > - How does this CL make it better? Added: Before change dates in certificate viewer are written using numbers only and sometimes it isn't clear, what they mean (for example 10/9/17 can mean 9 Oct 2017 or 10 Sep 2017). Patch changes to it to format, where month is written with words. Format is consistent for example with message about displaying offline page (in popup menu with site info).
Looks great! That CL description has all the content I was looking for! I wonder what you think about rewording the description a little bit though, to make the content a little bit clearer, maybe something like this: ### [Android] Simplify date format in certificate viewer Before this CL, the dates in the certificate viewer were displayed using only numbers. This can be confusing to the end user, since the ordering of date and month depends on the current device locale. For example, 10/9/17 can mean 9 Oct 2017 or 10 Sep 2017. This CL changes it to a format where the month is written with words, such as 10 Sep 2017. This is consistent with other parts of Chrome where we display dates, such as the messages around displaying offline pages in the popup menu with site information. See the bug for screenshot of before and after. BUG=682474 ###
Description was changed from ========== (Android) Changing date format in Cert. Viewer to clear and consistent one Before change dates in certificate viewer are written using numbers only and sometimes it isn't clear, what they mean (for example 10/9/17 can mean 9 Oct 2017 or 10 Sep 2017). Patch changes to it to format, where month is written with words. Format is consistent for example with message about displaying offline page (in popup menu with site info). BUG=682474 (contains screenshot) ========== to ========== [Android] Simplify date format in certificate viewer Before this CL, the dates in the certificate viewer were displayed using only numbers. This can be confusing to the end user, since the ordering of date and month depends on the current device locale. For example, 10/9/17 can mean 9 Oct 2017 or 10 Sep 2017. This CL changes it to a format where the month is written with words, such as 10 Sep 2017. This is consistent with other parts of Chrome where we display dates, such as the messages around displaying offline pages in the popup menu with site information. See the bug for screenshot of before and after. BUG=682474 ==========
On 2017/01/31 22:41:56, nyquist wrote: > Looks great! That CL description has all the content I was looking for! > > I wonder what you think about rewording the description a little bit though, to > make the content a little bit clearer, maybe something like this: > ### > [Android] Simplify date format in certificate viewer > > Before this CL, the dates in the certificate viewer were displayed using only > numbers. > > This can be confusing to the end user, since the ordering of date and month > depends on the current device locale. For example, 10/9/17 can mean 9 Oct 2017 > or 10 Sep 2017. > > This CL changes it to a format where the month is written with words, such as 10 > Sep 2017. This is consistent with other parts of Chrome where we display dates, > such as the messages around displaying offline pages in the popup menu with site > information. > > See the bug for screenshot of before and after. > > BUG=682474 > ### I'm very technical and honestly speaking I'm leaving writing nice descriptions many times to marketing people :) Thank you for editing my info -> I have copied to it "as is"
lgtm Thanks for doing this! I really do like the new format. Optional: Before submitting this CL, feel free to copy-paste the first line of the CL description into the subject of this code review to keep them consistent. The tool is weird as it doesn't keep them the same. It's up to you though.
The CQ bit was checked by marcin@mwiacek.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485904294511610, "parent_rev":
"60e6ff0ec09380ea502aa26d6480fc528b555eb8", "commit_rev":
"964e9655f9b576d009c0558facdbca3154f1ab09"}
Message was sent while issue was closed.
Description was changed from ========== [Android] Simplify date format in certificate viewer Before this CL, the dates in the certificate viewer were displayed using only numbers. This can be confusing to the end user, since the ordering of date and month depends on the current device locale. For example, 10/9/17 can mean 9 Oct 2017 or 10 Sep 2017. This CL changes it to a format where the month is written with words, such as 10 Sep 2017. This is consistent with other parts of Chrome where we display dates, such as the messages around displaying offline pages in the popup menu with site information. See the bug for screenshot of before and after. BUG=682474 ========== to ========== [Android] Simplify date format in certificate viewer Before this CL, the dates in the certificate viewer were displayed using only numbers. This can be confusing to the end user, since the ordering of date and month depends on the current device locale. For example, 10/9/17 can mean 9 Oct 2017 or 10 Sep 2017. This CL changes it to a format where the month is written with words, such as 10 Sep 2017. This is consistent with other parts of Chrome where we display dates, such as the messages around displaying offline pages in the popup menu with site information. See the bug for screenshot of before and after. BUG=682474 Review-Url: https://codereview.chromium.org/2645753002 Cr-Commit-Position: refs/heads/master@{#447373} Committed: https://chromium.googlesource.com/chromium/src/+/964e9655f9b576d009c0558facdb... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/964e9655f9b576d009c0558facdb... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
