Add an 'allow-top-navigation-with-user-interaction' sandbox flag.

Add an 'allow-top-navigation-with-user-interaction' sandbox flag.

This is a new flag for `<iframe sandbox="...">` which will allow a
sandboxed document to navigate top-level page only with a user activation (aka. gesture). This will allow, for example, a third-party advertisement to be safely sandboxed without breaking existing sandboxed contents.

Intent to Implement & Ship: 
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Flt2IixYQK4/RKMfll65AgAJ

BUG=662506
Review-Url: https://codereview.chromium.org/2645733002
Cr-Commit-Position: refs/heads/master@{#444687}
Committed: https://chromium.googlesource.com/chromium/src/+/7a2bf4d888a500a9db0772ce02a88adbb7be6aee

[Bin Lu, 2017-01-18 21:43:37]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 21:44:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bin Lu, 2017-01-18 21:47:14]

Description was changed from

==========
Add an 'allow-top-navigation-with-user-interaction' sandbox flag.

BUG=662506
==========

to

==========
Add an 'allow-top-navigation-with-user-interaction' sandbox flag.

This is a new flag for `<iframe sandbox="...">` which will allow a
sandboxed document to navigate top-level page only with a user activation (aka.
gesture). This will allow, for example, a third-party advertisement to be safely
sandboxed without breaking existing sandboxed contents.

Intent to Implement & Ship: 
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Flt2IixYQK4/RKMfll65...

BUG=662506
==========

[Bin Lu, 2017-01-18 21:47:14]

binlu@google.com changed reviewers:
+ mkwst@chromium.org, ojan@chromium.org, rbyers@chromium.org

[Bin Lu, 2017-01-18 21:48:05]

Does this LG (while I'm working on adding tests)? Thanks.

[Rick Byers, 2017-01-18 22:24:47]

rbyers@chromium.org changed reviewers:
+ japhet@chromium.org
- mkwst@chromium.org, ojan@chromium.org

[Rick Byers, 2017-01-18 22:24:47]

This seems reasonable to me, though I'm not an expert in the specific code here.
 +japhet@ who has been touching this code most recently and so is probably the
main person who should review the details (with mkwst and ojan as optional since
I know they're both pretty swamped).

Are you planning on submitting a HTML spec PR for this, or do you want to ask
domenic@ or mkwst@ to see if they're willing to do that?

Note that HTML spec changes now require web-platform-tests
(https://github.com/w3c/web-platform-tests) so you probably want to write your
test in web-platform-test style (like the other iframe sandbox tests there) and
land in LayoutTests for now.  Then once there's agreement on the spec change,
you can move the test out of LayoutTests into web-platform-test (which can now
by done by committing directly to LayoutTests/imported/wpt/).

[Bin Lu, 2017-01-18 22:53:28]

Thanks Rick for the quick review.

japhet@, could you take a look today or tomorrow? I'm hoping to land it in M57
(whose deadline is tomorrow).

It'll be great if domenic@ or mkwst@ is willing to do the spec part.

Just added some tests. 
Will look at how web-platform-tests works since it's new to me.
And will convert them accordingly once we don't the spec change.

Thanks,
Bin

On 2017/01/18 22:24:47, Rick Byers wrote:
> This seems reasonable to me, though I'm not an expert in the specific code
here.
>  +japhet@ who has been touching this code most recently and so is probably the
> main person who should review the details (with mkwst and ojan as optional
since
> I know they're both pretty swamped).
> 
> Are you planning on submitting a HTML spec PR for this, or do you want to ask
> domenic@ or mkwst@ to see if they're willing to do that?
> 
> Note that HTML spec changes now require web-platform-tests
> (https://github.com/w3c/web-platform-tests) so you probably want to write your
> test in web-platform-test style (like the other iframe sandbox tests there)
and
> land in LayoutTests for now.  Then once there's agreement on the spec change,
> you can move the test out of LayoutTests into web-platform-test (which can now
> by done by committing directly to LayoutTests/imported/wpt/).

[Nate Chapin, 2017-01-18 23:00:33]

Code changes LGTM

[Bin Lu, 2017-01-19 06:25:25]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 06:25:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bin Lu, 2017-01-19 06:55:36]

The CQ bit was checked by binlu@google.com

[Bin Lu, 2017-01-19 06:55:37]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/2645733002/#ps100001
(title: "Fix the tests finally!")

[commit-bot: I haz the power, 2017-01-19 06:55:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 09:20:46]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484808936895810,
"parent_rev": "b05d288f8a09314e59b4a9747a9775c4e5f5ba2f", "commit_rev":
"7a2bf4d888a500a9db0772ce02a88adbb7be6aee"}

[commit-bot: I haz the power, 2017-01-19 09:21:16]

Description was changed from

==========
Add an 'allow-top-navigation-with-user-interaction' sandbox flag.

This is a new flag for `<iframe sandbox="...">` which will allow a
sandboxed document to navigate top-level page only with a user activation (aka.
gesture). This will allow, for example, a third-party advertisement to be safely
sandboxed without breaking existing sandboxed contents.

Intent to Implement & Ship: 
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Flt2IixYQK4/RKMfll65...

BUG=662506
==========

to

==========
Add an 'allow-top-navigation-with-user-interaction' sandbox flag.

This is a new flag for `<iframe sandbox="...">` which will allow a
sandboxed document to navigate top-level page only with a user activation (aka.
gesture). This will allow, for example, a third-party advertisement to be safely
sandboxed without breaking existing sandboxed contents.

Intent to Implement & Ship: 
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Flt2IixYQK4/RKMfll65...

BUG=662506

Review-Url: https://codereview.chromium.org/2645733002
Cr-Commit-Position: refs/heads/master@{#444687}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a2bf4d888a500a9db0772ce02a8...
==========

[commit-bot: I haz the power, 2017-01-19 09:21:18]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/7a2bf4d888a500a9db0772ce02a8...